Remove alert presentation role (#1398)

department-of-veterans-affairs · Nov 13, 2024 · 1597e26 · 1597e26
1 parent 4076708
commit 1597e26
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 7 deletions.
diff --git a/packages/storybook/.storybook/preview.js b/packages/storybook/.storybook/preview.js
@@ -136,10 +136,5 @@ const observeDocsRoot = () => {
 }
 
 document.body.onload = function () {
-  // Fix for React 17/NVDA bug where React root is read as "clickable"
-  // https://github.com/nvaccess/nvda/issues/13262
-  // https://github.com/facebook/react/issues/20895
-  // document.querySelector('#root').setAttribute('role', 'presentation');
-
   observeDocsRoot();
 };
diff --git a/packages/web-components/src/components/va-alert/test/va-alert.e2e.ts b/packages/web-components/src/components/va-alert/test/va-alert.e2e.ts
@@ -12,7 +12,7 @@ describe('va-alert', () => {
       <va-alert class="hydrated" status="info">
         <mock:shadow-root>
           <div class="usa-alert usa-alert--info">
-            <div class="usa-alert__body" role="presentation">
+            <div class="usa-alert__body">
               <slot name="headline"></slot>
               <slot></slot>
             </div>

diff --git a/packages/web-components/src/components/va-alert/va-alert.tsx b/packages/web-components/src/components/va-alert/va-alert.tsx
@@ -180,7 +180,6 @@ export class VaAlert {
           <div
             class="usa-alert__body"
             onClick={this.handleAlertBodyClick.bind(this)}
-            role="presentation"
           >
             {status === 'continue' && (
               <va-icon