Fixing the html element's font-size so it will respect browser settings.

department-of-veterans-affairs · Dec 23, 2024 · 13a6381 · 13a6381
1 parent f86ab60
commit 13a6381
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 12 deletions.
diff --git a/packages/css-library/dist/stylesheets/base/va.css b/packages/css-library/dist/stylesheets/base/va.css
diff --git a/packages/css-library/dist/stylesheets/base/va.css.map b/packages/css-library/dist/stylesheets/base/va.css.map
diff --git a/packages/css-library/dist/stylesheets/core.css b/packages/css-library/dist/stylesheets/core.css
diff --git a/packages/css-library/dist/stylesheets/core.css.map b/packages/css-library/dist/stylesheets/core.css.map
diff --git a/packages/css-library/dist/stylesheets/formation-overrides/elements/typography.css b/packages/css-library/dist/stylesheets/formation-overrides/elements/typography.css
diff --git a/packages/css-library/dist/stylesheets/formation-overrides/elements/typography.css.map b/packages/css-library/dist/stylesheets/formation-overrides/elements/typography.css.map
diff --git a/packages/css-library/src/stylesheets/base/va.scss b/packages/css-library/src/stylesheets/base/va.scss
@@ -11,7 +11,7 @@ body {
 }
 
 html {
-  font-size: $em-base;
+  font-size: 100%; // Needs to be 100% to be able to grow and shrink with browser settings
   font-weight: 500;
 }
 
@@ -422,7 +422,7 @@ article > h1 {
   padding-left: scale-rem(1rem);
 }
 
-// used mostly in content-build, we should consider moving this over there 
+// used mostly in content-build, we should consider moving this over there
 .last-updated {
   margin-top: 1.5em;
   border-top: 2px solid $color-gray-light;
@@ -433,8 +433,8 @@ article > h1 {
 }
 
 // Feature style used on hub pages (example on /pension/how-to-apply), copied here from formation
-// ToDo - These should be replaced with web-components: 
-// https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/2338#top 
+// ToDo - These should be replaced with web-components:
+// https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/2338#top
 // https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/2341#top
 
 .feature {

diff --git a/packages/css-library/src/stylesheets/formation-overrides/elements/typography.scss b/packages/css-library/src/stylesheets/formation-overrides/elements/typography.scss
@@ -15,7 +15,7 @@
 
 html {
   font-family: tok.$font-family-sans;
-  font-size: vars.$em-base;
+  font-size: 100%; // Needs to be 100% to be able to grow and shrink with browser settings
 }
 
 body {
-Original file line number
+Diff line change
@@ Expand Up / @@ -15,7 +15,7 @@ @@
     html {
       font-family: tok.$font-family-sans;
-      font-size: vars.$em-base;
+      font-size: 100%; // Needs to be 100% to be able to grow and shrink with browser settings
     }
     body {
@@ Expand Down @@