Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates logging to include how the contention is classified #3925

Merged

Conversation

tyler-spangler6
Copy link
Contributor

What was the problem?

During the classification process, a claim for increase can either be classified using the diagnostic code or the contention text. Our logging only included if the contention was classified, but not how the contention was classified. This is important for us to know to be able to track diagnostic codes that we do not have mapped that we are able to classify via contention text. It can also help us add new Diagnostic Codes that are being sent to the service to help cover more increase contentions.

The example of the new logging is below:

  • If the contention is classified by diagnostic code:
{
    "vagov_claim_id": 100,
    "claim_type": "claim_for_increase",
    "classification_code": 8940,
    "classification_name": "Cancer - Musculoskeletal - Other",
    "contention_text": "unmapped contention text",
    "diagnostic_code": 5012,
    "is_in_dropdown": false,
    "is_lookup_table_match": true,
    "is_multi_contention": true,
    "endpoint": "/expanded-contention-classification",
    "classification_method": "diagnostic_code",
    "processed_contention_text": null,
    "date": "2025-01-02 10:09:02",
    "level": "info"
}
  • If the contention is classified by contention text:
{
    "vagov_claim_id": 100,
    "claim_type": "claim_for_increase",
    "classification_code": 8997,
    "classification_name": "Musculoskeletal, knee",
    "contention_text": "unmapped contention text [acl tear]",
    "diagnostic_code": 1234,
    "is_in_dropdown": false,
    "is_lookup_table_match": true,
    "is_multi_contention": true,
    "endpoint": "/expanded-contention-classification",
    "classification_method": "contention_text",
    "processed_contention_text": null,
    "date": "2025-01-02 10:09:02",
    "level": "info"
}
  • If the contention is not classified by either:
    {
    "vagov_claim_id": 100,
    "claim_type": "claim_for_increase",
    "classification_code": null,
    "classification_name": null
    "contention_text": "unmapped contention text",
    "diagnostic_code": 1234,
    "is_in_dropdown": false,
    "is_lookup_table_match": true,
    "is_multi_contention": true,
    "endpoint": "/expanded-contention-classification",
    "classification_method": "unmapped_contention",
    "processed_contention_text": null,
    "date": "2025-01-02 10:09:02",
    "level": "info"
    }

Associated tickets or Slack threads:

How does this fix it?1

How to test this PR

  • Unit tests are written to cover the logic of creating the field and that it is incorporated in the logs.

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Test Results

102 tests  ±0   102 ✅ ±0   17s ⏱️ -1s
 31 suites ±0     0 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit 0cc39ee. ± Comparison against base commit ff4e1cb.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

JaCoCo Test Coverage

Overall Project 68%

There is no coverage information present for the Files changed

@tyler-spangler6 tyler-spangler6 marked this pull request as ready for review January 2, 2025 17:40
@tyler-spangler6 tyler-spangler6 requested a review from a team as a code owner January 2, 2025 17:40
Copy link

@williamphelps13 williamphelps13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tyler-spangler6 tyler-spangler6 merged commit ab6d07c into develop Jan 7, 2025
15 checks passed
@tyler-spangler6 tyler-spangler6 deleted the conditions-add-classification-method-logging branch January 7, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants