Comment lint test due to flakiness) #3836
Conversation
There was a problem hiding this comment.
Per this discussion, we should comment out the specific flaky test, not the entire lint-and-test portion of the CI run. Let's go ahead and pair on this on Monday.
Details:
If you check the lint-and-test failure, you can track down the specific test [gov.va](http://gov.va/).vro.metricslogging.MetricLoggerServiceTest::testCreateDistributionPointsPayload() (see below):
Gradle Test Run :shared:lib-metrics:test > Gradle Test Executor 17 > MetricLoggerServiceTest > testCreateDistributionPointsPayload() FAILED
org.opentest4j.AssertionFailedError at MetricLoggerServiceTest.java:152
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
...
> Task :shared:lib-metrics:test
Gradle Test Run :shared:lib-metrics:test > Gradle Test Executor 17 > MetricLoggerServiceTest FAILED
20 tests completed, 1 failed
> Task :shared:lib-metrics:test FAILED
Failed tests:
FAILURE: Build failed with an exception.
- gov.va.vro.metricslogging.MetricLoggerServiceTest::testCreateDistributionPointsPayload()
* What went wrong:
Execution failed for task ':shared:lib-metrics:test'.
> There were failing tests. See the report at: file:///home/runner/work/abd-vro/abd-vro/shared/lib-metrics/build/reports/tests/test/index.html
BUILD FAILED in 10s
Test Results102 tests - 1 102 ✅ - 1 18s ⏱️ ±0s Results for commit f864cf8. ± Comparison against base commit 040ee76. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
JaCoCo Test Coverage
|
|
@gabezurita Thanks for your comment since this helped me find the specific test and comment it out as well as upgrade the gradle version that was also affecting test. Please review at your earliest convenience. |
shared/lib-metrics/src/test/java/gov/va/vro/metricslogging/MetricLoggerServiceTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Woops, think we accidentally re-requested over my last review:
#3836 (review)
What was the problem?
Lint-and-test stage in CI pipeline was flaky today and it had to be re-ran in order for it to pass. This blocked the PR from being merged unless it was successful.
How does this fix it?[^1]
Since we are shutting down VRO services, commenting this specific test out will prevent re-running this stage for future PRs.