Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out svc-bie-kafka workflows tied to inactive services #3814

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Comment out svc-bie-kafka workflows tied to inactive services #3814

merged 3 commits into from
Dec 3, 2024

Conversation

gabezurita
Copy link
Collaborator

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

Test Results

103 tests   - 33   103 ✅  - 33   17s ⏱️ -5s
 31 suites  -  8     0 💤 ± 0 
 31 files    -  8     0 ❌ ± 0 

Results for commit 97a81b3. ± Comparison against base commit 9164fd1.

This pull request removes 33 tests. 
gov.va.vro.services.bie.config.ContentionEventTest ‑ "testGenerateRabbitMQChannelName_channelNames(String, String).inputTopic=BIA_SERVICES_BIE_CATALOG_TST_CONTENTION_ASSOCIATED_TO_CLAIM_V02, bieChannel=svc_bie_kafka.bie_events_contention_associated"
gov.va.vro.services.bie.config.ContentionEventTest ‑ "testGenerateRabbitMQChannelName_channelNames(String, String).inputTopic=BIA_SERVICES_BIE_CATALOG_TST_CONTENTION_CLASSIFIED_V02, bieChannel=svc_bie_kafka.bie_events_contention_classified"
gov.va.vro.services.bie.config.ContentionEventTest ‑ "testGenerateRabbitMQChannelName_channelNames(String, String).inputTopic=BIA_SERVICES_BIE_CATALOG_TST_CONTENTION_COMPLETED_V02, bieChannel=svc_bie_kafka.bie_events_contention_completed"
gov.va.vro.services.bie.config.ContentionEventTest ‑ "testGenerateRabbitMQChannelName_channelNames(String, String).inputTopic=BIA_SERVICES_BIE_CATALOG_TST_CONTENTION_DELETED_V02, bieChannel=svc_bie_kafka.bie_events_contention_deleted"
gov.va.vro.services.bie.config.ContentionEventTest ‑ "testGenerateRabbitMQChannelName_channelNames(String, String).inputTopic=BIA_SERVICES_BIE_CATALOG_TST_CONTENTION_UPDATED_V02, bieChannel=svc_bie_kafka.bie_events_contention_updated"
gov.va.vro.services.bie.config.ContentionEventTest ‑ "testMapTopicToEvent_validTopics(String, ContentionEvent).inputTopic=BIA_SERVICES_BIE_CATALOG_TST_CONTENTION_ASSOCIATED_TO_CLAIM_V02, expectedEvent=CONTENTION_ASSOCIATED"
gov.va.vro.services.bie.config.ContentionEventTest ‑ "testMapTopicToEvent_validTopics(String, ContentionEvent).inputTopic=BIA_SERVICES_BIE_CATALOG_TST_CONTENTION_CLASSIFIED_V02, expectedEvent=CONTENTION_CLASSIFIED"
gov.va.vro.services.bie.config.ContentionEventTest ‑ "testMapTopicToEvent_validTopics(String, ContentionEvent).inputTopic=BIA_SERVICES_BIE_CATALOG_TST_CONTENTION_COMPLETED_V02, expectedEvent=CONTENTION_COMPLETED"
gov.va.vro.services.bie.config.ContentionEventTest ‑ "testMapTopicToEvent_validTopics(String, ContentionEvent).inputTopic=BIA_SERVICES_BIE_CATALOG_TST_CONTENTION_DELETED_V02, expectedEvent=CONTENTION_DELETED"
gov.va.vro.services.bie.config.ContentionEventTest ‑ "testMapTopicToEvent_validTopics(String, ContentionEvent).inputTopic=BIA_SERVICES_BIE_CATALOG_TST_CONTENTION_UPDATED_V02, expectedEvent=CONTENTION_UPDATED"
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

JaCoCo Test Coverage

Overall Project 68% ❌

There is no coverage information present for the Files changed

@gabezurita
Comment out svc-bie-kafka workflows tied to inactive services
18d0985 
- Prevent unnecessary execution and dependency/security updates.
- Added comments with context and links to relevant documentation:
  - Disabling issue: #3802
  - BIE Docs: #3753
@gabezurita gabezurita force-pushed the disable/svc-bie-kafka-workflows branch from 248afca to 18d0985 Compare December 3, 2024 00:25
@gabezurita gabezurita marked this pull request as ready for review December 3, 2024 01:09
@gabezurita gabezurita requested a review from a team as a code owner December 3, 2024 01:09
brostk
brostk reviewed Dec 3, 2024
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@gabezurita
Fix .github/workflows/container-healthchecks
64c2f4d 
- Added explicit execution of `COMPOSE_PROFILES="platform,svc" ./gradlew :dockerComposeUp` to ensure necessary platform and svc services are started.

Relevant error:
vro_ee-ep-merge-app_1 Up About a minute (unhealthy) There are unexpected unhealthy containers! Error: Process completed with exit code 2.

See PR comment: #3814 (comment)
@gabezurita
disable vro-streamlit in workflows
97a81b3 
#3814 (comment)
@gabezurita gabezurita enabled auto-merge December 3, 2024 15:55
dfitchett
dfitchett approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@dfitchett dfitchett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabezurita gabezurita merged commit a676c42 into develop Dec 3, 2024
16 checks passed
@gabezurita gabezurita deleted the disable/svc-bie-kafka-workflows branch December 3, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brostk brostk brostk approved these changes

@dfitchett dfitchett dfitchett approved these changes

@Ponnia-M Ponnia-M Awaiting requested review from Ponnia-M Ponnia-M is a code owner automatically assigned from department-of-veterans-affairs/benefits-vro-engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabezurita @dfitchett @brostk