Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Field to Track Testing Classifications #3813

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

tyler-spangler6
Copy link
Contributor

What was the problem?

This adds a field to the API models to accept from vets-api that can help us with a/b testing our new classification method. This field will also be logged to be able to filter on in DataDog to track our metrics.

Associated tickets or Slack threads:

How does this fix it?1

How to test this PR

  • Step 1
  • Step 22

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page.

  2. To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Test Results

103 tests   103 ✅  16s ⏱️
 31 suites    0 💤
 31 files      0 ❌

Results for commit 63ffc4d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

JaCoCo Test Coverage

Overall Project 68%

There is no coverage information present for the Files changed

@tyler-spangler6 tyler-spangler6 marked this pull request as ready for review December 3, 2024 16:12
@tyler-spangler6 tyler-spangler6 requested a review from a team as a code owner December 3, 2024 16:12
Copy link

@williamphelps13 williamphelps13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tyler-spangler6 tyler-spangler6 merged commit 7151d26 into develop Dec 3, 2024
15 checks passed
@tyler-spangler6 tyler-spangler6 deleted the conditions-new-api-param-for-testing branch December 3, 2024 17:53
tyler-spangler6 added a commit that referenced this pull request Dec 9, 2024
tyler-spangler6 added a commit that referenced this pull request Dec 9, 2024
* Revert "Add API Field to Track Testing Classifications (#3813)"

This reverts commit 7151d26.

* removed comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants