Add Expanded lookup table endpoint #3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo Test Coverage
|
williamphelps13
approved these changes
Oct 31, 2024
Comment on lines
+253
to
+254
| classification_code = classification["classification_code"] | ||
| classification_name = classification["classification_name"] |
There was a problem hiding this comment.
Would this have any benefit here (and in the next conditional)?
Suggested change
| classification_code = classification["classification_code"] | |
| classification_name = classification["classification_name"] | |
| classification_code = classification.get("classification_code") | |
| classification_name = classification.get("classification_name") |
There was a problem hiding this comment.
I think using dict[] is preferred if we are certain the key exists which we are since we have the defaults set in the lookup_tables.get() methods. I think the advantage of using dict.get() is that handles the keyerror using the default. I am good to switch it if it helps readability and consistency though.
tyler-spangler6
deleted the
conditions-626-expanded-classification-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This implements a new classification lookup table to classify Veteran contentions. The research for this new method is in Free Text Classification Research.
This establishes the new method and adds the endpoint. This will not be implemented in vets-api until we are able to conduct testing on the processing time and load testing on the API to ensure that it does not slow down the full submit process for the 526EZ.
Associated tickets or Slack threads:
How does this fix it?1
How to test this PR
pytestFootnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩