-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorize Generic user for Streamlit #3672
Conversation
…cation / authorization from github.
JaCoCo Test Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on laying a solid foundation here! The code LGTM overall (Python not being my main jam), and I’ve left a few questions to clarify design choices and better understand your approach! Thank you for figuring this out so fast!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
What was the problem?
Currently, anyone with access to the deployed url via CAG would be able access the application. There is no authentication or authorization protecting any part of the application.
Associated tickets or Slack threads:
How does this fix it?1
This adds a level of authentication via github OAuth apps. Anyone with a github account will be able to access the application as a basic user. Eventually more authorization will be added to only allow people who are part of the department-of-veterans-affairs organization and part of specific teams.
How to test this PR
./gradlew vro-streamlit:check
to run all checks/lints/unit tests../gradlew :vro-streamlit:docker
then runCOMPOSE_PROFILES="streamlit" ./gradlew :dockerComposeUp
to run the container. Then open browser to http://0.0.0.0:8501/ to view webpages.Home
page, click the login with github and authorize to view the BIE Events pages.Footnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩