Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request Reviewer Tasks #2534

Closed
wants to merge 1 commit into from
Closed

Pull Request Reviewer Tasks #2534

wants to merge 1 commit into from

Conversation

nelsestu
Copy link
Contributor

@nelsestu nelsestu commented Feb 2, 2024

Adds the concept of custom reviewer tasks. During the PR open event, this github action would be invoked. The action looks up the auto-assigned reviewers and then uses their github user name to check whether they have a python task defined under the .github/reviewer-tasks directory. If a file is found the action will invoke the file passing along the GITHUB_EVENT_PATH environment variable that is present in github actions. GITHUB_EVENT_PATH is a json file containing the details of the PR. This gives developers a full featured programming language with which to write a task of their choosing. In my case, my username nelsestu means I've included a task defined at .github/reviewer-tasks/nelsestu_task.py which invokes the reclaim.ai api to schedule a new task. With this PR review now in my reclaim task list, reclaim.ai will continue to schedule the review until it has been marked complete.

What was the problem?

Associated tickets or Slack threads:

  • #?

How does this fix it?1

How to test this PR

  • Step 1
  • Step 22

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page.

  2. To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline.

Adds the concept of custom reviewer tasks. During the PR open event, this github action would be invoked. The action looks up the auto-assigned reviewers and then uses their github user name to check whether they have a python task defined under the .github/reviewer-tasks directory. If a file is found the action will invoke the file passing along the GITHUB_EVENT_PATH environment variable that is present in github actions. GITHUB_EVENT_PATH is a json file containing the details of the PR. This gives developers a full featured programming language with which to write a task of their choosing. In my case, my username nelsestu means I've included a task defined at .github/reviewer-tasks/nelsestu_task.py which invokes the reclaim.ai api to schedule a new task. With this PR review now in my reclaim task list, reclaim.ai will continue to schedule the review until it has been marked complete.
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Test Results

148 tests  ±0   148 ✅ ±0   46s ⏱️ -1s
 39 suites ±0     0 💤 ±0 
 39 files   ±0     0 ❌ ±0 

Results for commit e53bf97. ± Comparison against base commit 21c430c.

Copy link
Contributor

github-actions bot commented Feb 2, 2024

JaCoCo Test Coverage

There is no coverage information present for the Files changed

Total Project Coverage 76.39%

Copy link
Contributor Author

@nelsestu nelsestu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing PR review from the command line

@nelsestu nelsestu closed this Aug 1, 2024
@nelsestu nelsestu deleted the pr-reviewer-tasks branch August 1, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant