Skip to content

Commit

Permalink
disable vro-streamlit in workflows
Browse files Browse the repository at this point in the history
  • Loading branch information
gabezurita committed Dec 3, 2024
1 parent 64c2f4d commit 97a81b3
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 22 deletions.
23 changes: 12 additions & 11 deletions .github/workflows/test-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,13 @@ jobs:
with:
files: domain-ee/**

- name: "Get changed vro-streamlit files"
if: '! inputs.run_all_tests'
id: vro-streamlit-changed-files-specific
uses: tj-actions/changed-files@v45
with:
files: vro-streamlit/**
# NOTE: The vro-streamlit service is currently disabled because it is not actively used.
# - name: "Get changed vro-streamlit files"
# if: '! inputs.run_all_tests'
# id: vro-streamlit-changed-files-specific
# uses: tj-actions/changed-files@v45
# with:
# files: vro-streamlit/**

- name: "Install Python"
if: inputs.run_all_tests || steps.changed-files-specific.outputs.any_changed == 'true' || steps.ee-changed-files-specific.outputs.any_changed == 'true'
Expand All @@ -182,8 +183,8 @@ jobs:
run: |
./gradlew :domain-ee:test
- name: "Run VRO Streamlit tests"
if: inputs.run_all_tests || steps.vro-streamlit-changed-files-specific.outputs.any_changed == 'true'
run: |
./gradlew :vro-streamlit:check
# echo "skipping tests for now..."
# NOTE: The vro-streamlit service is currently disabled because it is not actively used.
# - name: "Run VRO Streamlit tests"
# if: inputs.run_all_tests || steps.vro-streamlit-changed-files-specific.outputs.any_changed == 'true'
# run: |
# ./gradlew :vro-streamlit:check
21 changes: 11 additions & 10 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -182,13 +182,14 @@ services:
# depends_on:
# <<: [ *svc-depends-on ]

vro-streamlit:
profiles: ["all", "streamlit"]
image: va/abd_vro-vro-streamlit:latest
ports:
- "8501:8501"
environment:
<<: [*common-vars]
STREAMLIT_SERVER_PORT: 8501
networks:
- intranet
# NOTE: The vro-streamlit service is currently disabled because it is not actively used.
# vro-streamlit:
# profiles: ["all", "streamlit"]
# image: va/abd_vro-vro-streamlit:latest
# ports:
# - "8501:8501"
# environment:
# <<: [*common-vars]
# STREAMLIT_SERVER_PORT: 8501
# networks:
# - intranet
2 changes: 1 addition & 1 deletion settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ include ':shared:lib-hoppy'
include ':svc-bgs-api'
include ':svc-bip-api'
// include ':svc-bie-kafka' # See: https://github.com/department-of-veterans-affairs/abd-vro/issues/3802
include ':vro-streamlit'
// include ':vro-streamlit' # See: https://github.com/department-of-veterans-affairs/abd-vro/pull/3814#discussion_r1867826060

include ':domain-xample:xample-api-controller'
include ':domain-xample:xample-shared'
Expand Down

0 comments on commit 97a81b3

Please sign in to comment.