Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEAF 3288 address common logged errors #2628

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aerinkayne
Copy link
Contributor

Address some common errors logged in Dynatrace (frontend JS)

  1. Prevent a ReferenceError in the LEAF Inbox that occurs if the quick view is displayed

  2. Prevent a TypeError that can occur when the dialogController attempts to modify attributes of the cancel button.

  3. Prevent a TypeError that could occur due to an incorrect indicators.conditions value.
    When the Conditions Editor was released, a brief issue caused form packets to be exported with indicator.conditions set to 'null' instead of null. This update handles this value for existing forms and prevents it from being set if a form packet that has the value is imported.

Impact / Testing

  1. Inbox
    Open any form quick view. Dev Console Reference Error should no longer occur.

  2. Potentially anywhere dialogController is used. This error can be re-produced by modifying a template that uses the dialog controller instance (For example, print_form) and misspelling the id passed for the cancel button. Confirm that the error no longer occurs.

  3. Form Editor - Import Form, Request Editing and Preview areas
    Use Adminer to set an indicator's conditions to null (the string, not NULL from dropdown).
    -Confirm that no error occurs in the console on the form editing or print views.
    -Export the associated form, then re-import it. Confirm that the value for the imported form is NULL and not 'null'.

Prevent conditions set to 'null' for new form imports.
Handle existing forms if they contain conditions set to 'null'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant