LEAF 3288 address common logged errors #2628
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address some common errors logged in Dynatrace (frontend JS)
Prevent a ReferenceError in the LEAF Inbox that occurs if the quick view is displayed
Prevent a TypeError that can occur when the dialogController attempts to modify attributes of the cancel button.
Prevent a TypeError that could occur due to an incorrect indicators.conditions value.
When the Conditions Editor was released, a brief issue caused form packets to be exported with indicator.conditions set to 'null' instead of null. This update handles this value for existing forms and prevents it from being set if a form packet that has the value is imported.
Impact / Testing
Inbox
Open any form quick view. Dev Console Reference Error should no longer occur.
Potentially anywhere dialogController is used. This error can be re-produced by modifying a template that uses the dialog controller instance (For example, print_form) and misspelling the id passed for the cancel button. Confirm that the error no longer occurs.
Form Editor - Import Form, Request Editing and Preview areas
Use Adminer to set an indicator's conditions to null (the string, not NULL from dropdown).
-Confirm that no error occurs in the console on the form editing or print views.
-Export the associated form, then re-import it. Confirm that the value for the imported form is NULL and not 'null'.