LEAF 4597 - move orgchart keyboard info banner #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerinkayne
requested review from
mgaoVA,
pete-nerantzinis,
Pelentan,
shaneodd,
jampaul3 and
nk2136
shaneodd
approved these changes
Dec 13, 2024
jampaul3
approved these changes
Dec 17, 2024
Pelentan
approved these changes
Dec 18, 2024
Pelentan
added
the
With QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This element displaying keyboard instructions has been moved to the right side under the editor buttons where it is less likely to overlap with position cards. It will also not show unless a card is being moved by keyboard arrows.
When it is showing, there is a checkbox available to hide the additional information (pending some feedback - it might be fine to remove this since the keyboard info will not usually show)
Other:
minor UX update to re-paint connectors after a position is saved if a card has been moved by keyboard
Testing / Impact
This update is specific to the orgchart editor (Nexus -> browser -> edit orgchart)
Keyboard instruction location has been moved and should not display unless a card is being moved with keyboard arrow keys. Confirm that card behaviors have not otherwise changed.