LEAF 4435 dragdrop enhancements #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rag-drop troubleshooting
aerinkayne
requested review from
mgaoVA,
pete-nerantzinis,
Pelentan,
shaneodd,
jampaul3 and
nk2136
jampaul3
approved these changes
Nov 22, 2024
Pelentan
approved these changes
Nov 22, 2024
shaneodd
approved these changes
Nov 22, 2024
Pelentan
added
the
With QA
… for common class module
jampaul3
previously approved these changes
Dec 4, 2024
shaneodd
previously approved these changes
Dec 4, 2024
Pelentan
previously approved these changes
Dec 4, 2024
Pelentan
dismissed stale reviews from shaneodd, jampaul3, and themself
The base branch was changed.
Pelentan
approved these changes
Dec 4, 2024
shaneodd
approved these changes
Dec 4, 2024
jampaul3
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves presentation of drag-drop process by making what is being dragged and where it is being dragged to more obvious.
Click to move options can still be made visible by taking any action that moves focus to the question (clicking in area) or upon tabbing.
Logic updates to click to move buttons (potentially revisited in future). Buttons will not appear if the question has no move options, and Up/Down button will be disabled (not tab-able) if the question is at the top/bottom
Impact / Testing
Form Editor
-Specific to drag-drop behavior but regression testing should still be performed
-drag-drop (with question top-left handle) behaves as expected
-click to move buttons still behave as expected.
***************** Pushed solo *************
API tests:
Updating DB Schema: Request Portal... OK
Updating DB Schema: Local Nexus (Orgchart)... OK
Updating DB Schema: National Nexus (Orgchart)... OK
PASS
ok LEAF/API-tester 11.318s
E2E Tests:
sprint85c4_e2e.txt