LEAF-4577 - Print to PDF Image #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneodd
requested review from
mgaoVA,
Pelentan,
aerinkayne,
pete-nerantzinis,
jampaul3,
nk2136 and
KCN8
as code owners
aerinkayne
previously approved these changes
Oct 30, 2024
jampaul3
previously approved these changes
Oct 30, 2024
…to content link and make the first entry load properly.
Pelentan
previously approved these changes
Nov 4, 2024
Pelentan
added
the
With QA
Pelentan
dismissed stale reviews from jampaul3, aerinkayne, and themself
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Images were not allowed in the print to pdf, so for example the image upload would not show when printing a pdf using the browsers print to pdf functionality.
The fix
Adjusted print style sheet to allow images within the request.
** Other Issues Fixed **
New
Old
Testing