LEAF 3428 remediate 508 issues (pass 1) #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm redundant alt text from portal templates. rm alt attrs from unsupported elements. prevent reading of some emojis. add titles for some images for better user experience, add some missing labels. improve alt description of VA logo.
project - find img els missing alt attrs by regex and update.
site elements dirs and js file alt attrs. contrast fixes(lighthouse). add missing label elements. add workflowActions tabbing. html lang en. update chosen role attr val to combobox. rm confirmed unused method.
…pes where flagged
do not show connection options for built in workflows. add aria status elements to read chosen dropdown selection. focus step selector on step modal close.
mv action select to step info, alphabetize. wrap interactive icons with buttons, cleanup template.
stepinfo selector specificity and reopen behavior. some remaining spans changed to buttons. side menu order.
Pelentan
requested changes
Jan 19, 2024
…on't get called twice
Pelentan
approved these changes
Jan 19, 2024
shaneodd
approved these changes
Jan 23, 2024
jampaul3
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a number of site wide 508 related issues, with some specific focus on the workflow editor.
General updates to template(tpl), report, and js files include modifying or adding alt attributes, labels, titles, replacing spans/divs with buttons, improving contrast, adding lang attributes. Following confirmation, some unused methods were also removed. A tabbing issue for vue side modals was also addressed.
Testing / Impact
Site Wide
Changes outside of mod_workflow should not be significantly obvious to non screen reader users. Changes here are generally not code-heavy, but regression testing of general site/nav behavior should still be undertaken in case of typos.
Workflow Editor
mod_workflow.tpl has a number of behavior related changes mostly related to modal behaviors and workflow step editing.
In addition to keyboard nav ability, the expected behaviors of the workflow editor functions should be confirmed.