LEAF 4169 IFTHEN - new controllers and operators #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gic to server, printform
Use some instead of every for operator trigger. Filter out NaN values and handle some edge cases. Add vue side code and rebuild
Adjust close and toolip behavior, simplify some logic. Update operator selection. Improve choicesJS triggers. Initial add number and currency parent controls.
Update endpoint for form indicators get and simplify condition setup logic. Fix issue with modal scrolling
…dicator editor name
Pelentan
approved these changes
Jan 19, 2024
| @@ -224,13 +242,23 @@ export default { | |||
| getOperatorText(condition = {}) { | |||
| const parFormat = condition.parentFormat.toLowerCase(); | |||
| let text = condition.selectedOp; | |||
| switch(text) { | |||
|
|
|||
| const op = condition.selectedOp; | |||
There was a problem hiding this comment.
This bit gets repeated a lot. We might want to look at pulling it out into into a class/function that can be used by everything that needs it.
jampaul3
approved these changes
Jan 23, 2024
shaneodd
approved these changes
Jan 30, 2024
Pelentan
added
the
With QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds number and currency to available controller questions.
Adds comparison options:
These options are available if the controller format is number or currency, or if other controllers include number in their options. A number type input field will appear if one of these operators is chosen.
Adjusts save/remove behavior:
Modal now has an explicit close button and does not automatically close on save/remove.
Other updates:
Changed data structures for some longer arrays and simplified setup.
Testing / Impact
Condition Entry
Confirm app loads as expected and conditions can be added, removed and edited as expected.
Changes made to the form should be immediately reflected in the ifthen app without needing to reload the page. If there are multiple conditions on a question, toggling between list items should not cause any unexpected behaviors.
Form Entry
Ensure that new and prior controller comparisons behave as expected.