Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaf 4208 - Resolve issue related to incorrect "custom" designation #2271

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

mgaoVA
Copy link
Collaborator

@mgaoVA mgaoVA commented Jan 11, 2024

This resolves an issue where templates are incorrectly listed as "custom".

Steps to reproduce issue:

  • Precondition: The "intial_form" and "form" templates have not been customized.
  1. Navigate to the Template Editor
  2. Modify the "initial_form" template
  3. Click refresh
  4. Note that the "form" template is incorrectly listed with a "custom" flag.

Potential Impact

None, because there are no external dependencies on api/template and api/emailTemplates.

Testing

  • The issue cannot be reproduced

- remove redundant json_encode
- remove redundant admin-only message
@mgaoVA mgaoVA changed the title Resolve issue related to incorrect "custom" flags Resolve issue related to incorrect "custom" designation Jan 12, 2024
Copy link
Collaborator

@Pelentan Pelentan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we get fully rolling again, we need to have a sit down with all developers and hash out how we want to work the controler returns and like.

@mgaoVA
Copy link
Collaborator Author

mgaoVA commented Jan 12, 2024

Once we get fully rolling again, we need to have a sit down with all developers and hash out how we want to work the controler returns and like.

Yeah, I plan on outlining some lessons learned by walking through my recent PRs.

@Pelentan Pelentan added the With QA Ticket is to QA. No changes unless pulled back to in progress label Jan 19, 2024
@jampaul3 jampaul3 changed the title Resolve issue related to incorrect "custom" designation 4208 - Resolve issue related to incorrect "custom" designation Jan 22, 2024
@jampaul3 jampaul3 changed the title 4208 - Resolve issue related to incorrect "custom" designation Leaf 4208 - Resolve issue related to incorrect "custom" designation Jan 22, 2024
@Pelentan Pelentan added the Merge&Test Ready to be put in the next release candidate label Jan 22, 2024
@Pelentan Pelentan changed the base branch from master to rc/2024-01-23/Sprint-67-c1 January 23, 2024 18:30
@Pelentan Pelentan merged commit 95e5488 into rc/2024-01-23/Sprint-67-c1 Jan 23, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge&Test Ready to be put in the next release candidate With QA Ticket is to QA. No changes unless pulled back to in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants