LEAF-3190 prevent built in workflow modification #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerinkayne
requested review from
mgaoVA,
Pelentan,
raphaelfretter,
shaneodd and
jampaul3
Pelentan
requested changes
Jan 8, 2024
| }; | ||
| let seriesData = { | ||
| AutomatedEmailReminders: { | ||
| 'Automate Email Group': auto.AutomatedEmailReminders.AutomateEmailGroup, |
There was a problem hiding this comment.
Do we need to think about having "default" values for these? Or are we sure there will always be values and these assignments will never fail to a null?
There was a problem hiding this comment.
This part was also unchanged. I think it should be ok though - if stepData isn't null, the field should have these. The only one that was in question (because emails by date was added later) was Date Selected, which already has a default value. If additional kinds of stepData are added in the future I agree we should re-visit this, but I also don't want to mess with email reminder default values without looking at the related functionality in more detail.
jampaul3
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an update to prevent users from creating a Requestor --> End connection on build in workflows. This correction is necessary because it creates an unavoidable help desk ticket as the user cannot undo this change.
Also prevents duplication of built in workflows and provides more obvious feedback about modifications to built-in workflow being restricted.
Impact / Testing
Workflow Editor
-It should no longer be possible to modify the initial requestor --> step connection on built in workflows.
-Confirm that custom workflows still behave as expected.