LEAF 4139 update keypress listeners in orgchartForm #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerinkayne
requested review from
mgaoVA,
pete-nerantzinis,
Pelentan,
jrodcode,
AmandaSumner,
raphaelfretter,
maxrichardjr,
shaneodd and
jampaul3
Pelentan
approved these changes
Nov 15, 2023
shaneodd
approved these changes
Nov 15, 2023
maxrichardjr
approved these changes
Nov 15, 2023
raphaelfretter
approved these changes
Nov 15, 2023
Pelentan
added
the
With QA
jampaul3
approved these changes
Nov 16, 2023
AmandaSumner
approved these changes
Nov 16, 2023
AmandaSumner
added
rc-ready
mgaoVA
requested changes
Nov 17, 2023
LEAF_Nexus/js/orgchartForm.js
Outdated
| event | ||
| ) { | ||
| if (event.which == 13) { | ||
| $("#" + dialog.btnSaveID).trigger("click"); | ||
| setTimeout(() => { //timeout needed for ind 2 chosen dropdown |
There was a problem hiding this comment.
Not sure what else might need to be reworked, but timeouts should not be used as they are less deterministic than typical event handlers.
There was a problem hiding this comment.
I found another (and I agree better) solution to this which should result in the behavior being what it had been previously. If the chosen dropbox is open, the first 'enter' will just close it.
I had looked at the orgchart indicator formats and the position case looked like the only one that had a field with a dropdown - if this is not true I can also add this elsewhere.
maxrichardjr
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the .keypress listeners in the Nexus orgchartForm js file to .on("keydown" listeners.
This should restore enter-save functionality of Nexus employee, position and group modals. These were not changed in the recent update but seem to have been impacted by the addition of a dialogController modal keydown listener.
The deprecated/removed jQuery size() method was also replaced by the .length property to fix a separate uncovered error.
Impact/Testing
Nexus side, editable (check write access) position, group and employee fields should save when enter is pressed in orgForm modals. Confirm that these fields consistently save correctly (particularly the Position 'Pay Plan' field, which required a short timeout for the chosen dropdown).
Confirm that updating a position Total Headcount field does not result in an error.