Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaf 4084 - custom emails added to subordinate #2223

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Leaf 4084 - custom emails added to subordinate #2223

merged 6 commits into from
Nov 21, 2023

Conversation

jampaul3
Copy link
Contributor

@jampaul3 jampaul3 commented Nov 6, 2023

Summary:
This adds the custom email templates created on the Primary site to the list of what gets pushed to a subordinate.

Potential Impact:
The files are getting copied over, I'm not sure if there are db entries that need to be copied over as well or not. If so that will need to be added.

Testing:

  1. On the primary site. create a custom email, assign it to a workflow
  2. push changes out to the subordinates
  3. create a request and make sure the custom email is received.

@jampaul3 jampaul3 self-assigned this Nov 6, 2023
@jampaul3 jampaul3 requested a review from mgaoVA November 7, 2023 13:52
@jampaul3 jampaul3 requested a review from shaneodd November 8, 2023 15:04
mgaoVA
mgaoVA requested changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@mgaoVA mgaoVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are DB changes that need to occur for emails to work on subordinate sites.

For clarity, if the DB related changes were intended to be put in a separate PR, this should be noted in the title as a part 1 of 2.

LEAF_Request_Portal/utils/LEAF_importStandardConfig.php Outdated Show resolved Hide resolved
LEAF_Request_Portal/utils/LEAF_importStandardConfig.php Show resolved Hide resolved
LEAF_Request_Portal/utils/LEAF_importStandardConfig.php Outdated Show resolved Hide resolved
@jampaul3 jampaul3 requested a review from mgaoVA November 13, 2023 14:56
@jampaul3 jampaul3 requested a review from Pelentan November 15, 2023 20:07
@Pelentan Pelentan added the With QA Ticket is to QA. No changes unless pulled back to in progress label Nov 15, 2023
@Pelentan Pelentan changed the base branch from master to rc/2023-21-14/Sprint-65-c2 November 21, 2023 14:30
@Pelentan Pelentan merged commit 24ef710 into rc/2023-21-14/Sprint-65-c2 Nov 21, 2023
3 of 6 checks passed
@jampaul3 jampaul3 deleted the feature/Leaf-4084/add_email_and_events_to_sub_export branch August 16, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneodd shaneodd shaneodd approved these changes

@maxrichardjr maxrichardjr maxrichardjr approved these changes

@raphaelfretter raphaelfretter raphaelfretter approved these changes

@jrodcode jrodcode jrodcode approved these changes

@aerinkayne aerinkayne aerinkayne approved these changes

@Pelentan Pelentan Pelentan approved these changes

@pete-nerantzinis pete-nerantzinis Awaiting requested review from pete-nerantzinis

@AmandaSumner AmandaSumner Awaiting requested review from AmandaSumner

@mgaoVA mgaoVA Awaiting requested review from mgaoVA

Assignees

@jampaul3 jampaul3

Labels
enhancement feature With QA Ticket is to QA. No changes unless pulled back to in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jampaul3 @mgaoVA @Pelentan @aerinkayne @jrodcode @raphaelfretter @maxrichardjr @shaneodd