Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEAF_3975_FY23_WASA_Findings - 404 Issue #2211

Closed
wants to merge 3 commits into from

Conversation

jrodcode
Copy link
Contributor

@jrodcode jrodcode commented Oct 26, 2023

Summary:

When a user enters an incorrect URL in the browser, the server will now present a customized 404 page. This is in response to a finding from the WASA report, which pointed out that the server previously displayed server-related information instead of a user-friendly error message to indicate that the requested page or file does not exist. The changes to NGINX file are on a different repository at https://github.com/department-of-veterans-affairs/LEAF-infrastructure/pull/122. These enhancements involve NGINX settings to manage the handling and display of 404 pages.

Testing:

To test this locally, follow these steps:

  1. Change the value of var homepageURL from "/" to "/LEAF_Request_Portal/".

  2. Update the default.conf file settings located in Docker in NGINX /etc/nginx/conf.d/ by applying the changes found in the LEAF infrastructure Pull Request (PR).

  3. To trigger the 404 page, use the following example URL:
    https://localhost/LEAF_Request_Portal/apple
    Typing the example URL will display the customized 404 page.

Copy link
Collaborator

@mgaoVA mgaoVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in PR#122 in the Infrastructure repo.

Copy link
Collaborator

@mgaoVA mgaoVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to move this file into the infrastructure repo.

A 404 page is meant to work across the entire domain. Currently it looks like it's structured within the Request Portal -- what if the 404 is being generated from Nexus or anywhere else?

Might need additional coordination with @Pelentan

@Pelentan Pelentan closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants