LEAF 3188 fileupload and image format template updates #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerinkayne
requested review from
mgaoVA,
pete-nerantzinis,
Pelentan,
AmandaSumner,
raphaelfretter,
maxrichardjr,
shaneodd and
jampaul3
maxrichardjr
approved these changes
Oct 27, 2022
shaneodd
approved these changes
Oct 27, 2022
jampaul3
approved these changes
Oct 28, 2022
pete-nerantzinis
approved these changes
Nov 2, 2022
raphaelfretter
approved these changes
Nov 3, 2022
Pelentan
requested changes
Nov 8, 2022
aerinkayne
added
the
review/comment only
maxrichardjr
approved these changes
Nov 9, 2022
maxrichardjr
deleted the
enhance/LEAF-3188/upload_format_question_updates
branch
aerinkayne
restored the
enhance/LEAF-3188/upload_format_question_updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PENDING: uncovered during testing on demo1:
In the dev environment nginx will return a response in the case of error scenarios (some config variables also determine this state), whereas on live it does not. Implementing fastcgi and config updates should resolve this difference. However, until this occurs, the error handling sections of this branch cannot be properly tested on the live environment.
Replaces the iframes used for file attachments in the subindicators template with standard input type=file elements. Associated prior code in other templates is being retained for use in custom subindicators files, which will continue to use these older templates.
Also adjusts some styling to meet contrast recommendations, fixes a button display issue and updates some error message verbiage.
Any code associated with file deletions will be handled in a future ticket to resolve uncovered issues that are unrelated to this update.