Leaf 4210 - updated sync services to clean system admins

department-of-veterans-affairs · Jan 23, 2024 · 3f123e2 · 3f123e2
1 parent 4849fed
commit 3f123e2
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 3 deletions.
diff --git a/LEAF_Request_Portal/sources/Group.php b/LEAF_Request_Portal/sources/Group.php
@@ -419,7 +419,7 @@ public function deactivateMember($member, $groupID): void
      *
      * @return void
      */
-    public function removeMember($member, $groupID): void
+    public function removeMember($member, $groupID, $backupID = ''): void
     {
         if (is_numeric($groupID) && $member != '') {
             $this->dataActionLogger->logAction(DataActions::PRUNE, LoggableTypes::EMPLOYEE, [
@@ -428,12 +428,13 @@ public function removeMember($member, $groupID): void
             ]);
 
             $vars = array(':userID' => $member,
-                          ':groupID' => $groupID);
+                          ':groupID' => $groupID,
+                          ':backupID' => $backupID);
             $sql = 'DELETE
                     FROM `users`
                     WHERE (`userID` = :userID
                         AND `groupID` = :groupID
-                        AND `backupID` = "")
+                        AND `backupID` = :backupID)
                     OR (`groupID` = :groupID
                         AND `backupID` = :userID)';
 

diff --git a/LEAF_Request_Portal/sources/System.php b/LEAF_Request_Portal/sources/System.php
@@ -796,9 +796,59 @@ public function syncSystem(\Orgchart\Group $nexus_group): string
             $this->updateGroup($group['groupID'], $oc_db);
         }
 
+        $this->cleanupSystemAdmin();
+
         return 'Syncing has finished. You are set to go.';
     }
 
+    /**
+     *
+     * @return void
+     * 
+     */
+    private function cleanupSystemAdmin(): void
+    {
+        // get all portal users with groupID = 1
+        $groups = new Group($this->db, $this->login);
+
+        $admins = $groups->getMembers(1);
+
+        // create an array of users with their backups
+        $admin_list = array();
+
+        foreach ($admins['data'] as $admin) {
+            if ($admin['backupID'] != '') {
+                $admin_list[$admin['backupID']]['backup'][] = $admin['userName'];
+            }
+        }
+
+        // get all primary users from nexus with their backups
+        $dir = new VAMC_Directory();
+        $oc_db = OC_DB;
+        $employee = new \Orgchart\Employee($oc_db, $this->login);
+        $check_list = array();
+
+        foreach ($admin_list as $key => $admin) {
+            $nexus_user = $dir->lookupLogin($key, false, true, false);
+            $backups = $employee->getBackups($nexus_user[0]['empUID']);
+            $check_list[$key]['backup'] = array();
+
+            foreach ($backups as $backup) {
+                $check_list[$key]['backup'][] = $backup['userName'];
+            }
+        }
+
+        // check that all the backups are still there, if not remove them from portal
+
+        foreach ($admin_list as $key => $user) {
+            foreach ($user['backup'] as $backup) {
+                if (!in_array($backup, $check_list[$key]['backup'])) {
+                    $groups->removeMember($backup, 1, $key);
+                }
+            }
+        }
+    }
+
     /**
      * getOrgchartImportTags retrieves
      *