Report Builder Tests #6

nk2136 · 2024-10-16T20:42:54Z

This includes several new tests for the Report Builder.

The report builder table displays selected data columns.
The user is redirected to the search filter page on the modify filter click.
Connected forms open on UID link click.
Pop-up modal opens and updates the title on the title column value click.
Take action allows users to perform necessary form actions.
Connected forms open on the Share Report button click.
Click on the edit labels button and also on the JSON button.
The user can share the report.
Validate Edit Labels/ Json button is working.
Validate create row button is functional.
Fill Single text.
Fill Multi-Line text.
Modify the Search with a logical filter.
Assigned group from check
Edit Report title

…-results

nk2136 · 2024-10-17T05:12:03Z

end2end/playwright.config.ts

end2end/tests/reportBuilder.spec.ts

mgaoVA · 2024-10-25T01:33:48Z

end2end/tests/reportBuilder.spec.ts

+    await page.getByRole('button', { name: 'Generate Report' }).click();
+});
+
+test("Edit Report Title", async ({ page }) => {


Error: locator.click: Test timeout of 30000ms exceeded. Call log: - waiting for getByRole('cell', { name: 'TestForm_NonadminCannotCancelOwnSubmittedRecord_new' })

Your database probably includes content that doesn't exist in the standardized version. Run the API tester to restore your local database back to the standard.

end2end/tests/reportBuilder.spec.ts

nk2136 · 2024-10-29T20:37:15Z

mgaoVA · 2024-10-31T19:49:09Z

end2end/README.md

@@ -2,19 +2,111 @@

 TODO: Add overview

+# LEAF Automated Tests


Note instructions have been updated in: #9 , Please start from this version.

Maybe a step needs to be added to explain that the API tester must be run first before doing any work on e2e tests.

mgaoVA · 2024-10-31T20:06:09Z

Changing back to draft.

Tests still include steps that are not related to the description -- the excess steps should either be removed, or the test description should be updated to reflect its behavior.

Please remove all references to { timeout: 5000 }, there's no need to define this manually.

As previously mentioned, the API tester must be run before running the e2e tests, otherwise there will be inconsistent results:

mgaoVA · 2024-11-14T22:15:22Z

end2end/README.md

@@ -12,33 +12,29 @@ LEAF uses Playwright for end-to-end testing. The test database is populated and
 3. On the command line: Navigate to the location where the development environment is installed
 4. Change directory into `LEAF-Automated-Tests/end2end`
 5. Install Playwright development tools:
-```


Please preview the output before committing changes like this:

mgaoVA · 2024-11-14T22:21:20Z

end2end/tests/reportBuilder.spec.ts

+
+test("Take Action allow user to perform necessary form Action", async ({ page }) => {
+    await page.goto("https://host.docker.internal/Test_Request_Portal/?a=reports&v=3&query=N4IgLgpgTgtgziAXAbVASwCZJHSAHASQBEQAaEAez2gEMwKpsBCAXjJBjoGMALbKCHAoAbAG4Qs5AOZ0I2AIIA5EgF9S6LIhAYIwiJEmVqUOg2xtynMLyQAGabIXKQKgLrkAVhTQA7BChwwOgBXBHccBjAkYDUQYTQYNCjEAEZbdPJ4xLAAeQAzPLh9OxUgA&indicators=NobwRAlgdgJhDGBDALgewE4EkAiYBcYyEyANgKZgA0YUiAthQVWAM4bL4AMAvpeNHCRosuAi2QoAri2a0G%2BMMzboOeHn0iwEKDDgWJ4RVFABCk5Giiz6jRdWWqeAXSA%3D");
+    const actionRow = page.getByRole('row', { name: '951 Take Action Available for' });


This test fails on subsequent runs, because no more actions are available for record 951.

I'd recommend using a selector such as "first button", recording the record ID, and then navigating to the record to validate that the "testing purpose" comment exists.

fixed and implemented the suggested changes

mgaoVA · 2024-11-14T22:31:26Z

end2end/tests/reportBuilder.spec.ts

+    await page.goto("https://host.docker.internal/Test_Request_Portal/?a=reports&v=3&query=N4IgLgpgTgtgziAXAbVASwCZJHSAHASQBEQAaEAez2gEMwKpsBCAXjJBjoGMALbKCHAoAbAG4Qs5AOZ0I2AIIA5EgF9S6LIhAYIwiJEmVqUOg2xtynMLyQAGabIXKQKgLrkAVhTQA7BChwwOgBXBHccBjAkYDUQYTQYNCjEAEZbdPJ4xLAAeQAzPLh9OxUgA&indicators=NobwRAlgdgJhDGBDALgewE4EkAiYBcYyEyANgKZgA0YUiAthQVWAM4bL4AMAvpeNHCRosuAi2QoAri2a0G%2BMMzboOeHn0iwEKDDgWJ4RVFABCk5Giiz6jRdWWqeAXSA%3D");
+    await page.getByRole('button', { name: 'Share Report' }).click();
+    await page.getByText('https://host.docker.internal/').click();
+    const emailReport = page.getByRole('button', { name: 'Email Report' });


Because the scope of this test is to validate that the Share Report button works, this test should navigate to the link and verify that the link works.

mgaoVA · 2024-11-14T22:33:01Z

end2end/tests/reportBuilder.spec.ts

+    await emailReport.click();
+});
+
+test("Validate JSON button", async ({ page }) => {


Similar to my comment above, this feature is only useful if the generated link is functional. Therefore the test should ensure that the link works.

mgaoVA · 2024-11-14T22:35:56Z

end2end/tests/reportBuilder.spec.ts

+    await page.getByText('Assigned Person 2').click();
+    await page.getByRole('button', { name: 'Generate Report' }).click();
+    const createButton = page.getByRole('button', { name: 'Create Row' });
+    await expect(createButton).toBeVisible();


Observe what happens when you click "Create Row".

We should expect that a new record is created, and shows up on the top. Note that the newly created row has "untitled" in its Title column.

new row button functionality is checked and new row is created with 'untitled' in its Title column.

mgaoVA · 2024-11-14T22:36:55Z

end2end/tests/reportBuilder.spec.ts

+    await page.getByRole('button', { name: "Edit Labels" }).click();
+    await page.getByRole('button', { name: 'Save Change' }).click();


mgaoVA · 2024-11-14T22:37:54Z

end2end/tests/reportBuilder.spec.ts

+    await expect(createButton).toBeFocused();
+});
+
+test('Modify search with AND logical filter', async ({ page }) => {


Suggested change

test('Modify search with AND logical filter', async ({ page }) => {

test('Modify search with AND logical filter (UI only, does not validate filter results)', async ({ page }) => {

Clarify that this test does not actually test the logical component, only the UI,

mgaoVA · 2024-11-15T01:06:56Z

end2end/tests/reportBuilder.spec.ts

 });
+
+test("Select multiple filter using AND/OR,", async ({ page }) => {


Suggested change

test("Select multiple filter using AND/OR,", async ({ page }) => {

test('Select multiple filter using AND/OR (UI only, does not validate filter results)', async ({ page }) => {

As before: if these tests are not going to check the accuracy of resulting data, we don't want to give a false impression. Therefore, clarification is needed to explain this only tests UI components.

mgaoVA · 2024-11-15T01:20:44Z

end2end/tests/reportBuilder.spec.ts

+    await page.goto("https://host.docker.internal/Test_Request_Portal/?a=reports&v=3&query=N4IgLgpgTgtgziAXAbVASwCZJAVztASQBEQAaEAewAdoBDMCqbAXjJBnoGMALbNgc3oRsAQQByJAL6l0WRCE5D%2BjAJ7E21OgybzW5DmB7YAZoxgB9AKwRaABgDsAodgDyAJRDTZ2DBAA2EJBY5JpQ9IwsbAZGiLbkgpCiEp4AuuQAVhRoAHYIKCD4UABuaJzC5DloYGjhUGK0MMJpBYxgSMDSIPyBRPS0SMggAJxsACxsjuQAzCDNfmgwVUgAjLZr5POLYC7GxvhtsZJAA%3D%3D&indicators=NobwRAlgdgJhDGBDALgewE4EkAiYBcYyEyANgKZgA0YUiAthQVWAM4bL4AMAvpeNHCRosuAizLoAbggrVaDfGGZt0HPDz6RYCFBhyLoxCLvTN5jJdRVqN%2FbUL2iwieEVRQAQgFdkaKGfoLZXYuXjtBE30CAE4AhQIAQRYWCABzKDIYAAIAcXRULwAHYNVQzQEdYSiwABY4iwBZLxIiLJJoMizkMgAPDisQ9TCtCKqnAHZ6xQAlRDhUEpthiocRRQBmKYIAZWhU8jaOrt7%2B1kGeAF0gA%3D");
+    const firstText = page.getByRole("cell", { name: "4331" });
+    await firstText.click();
+    await page.getByLabel('Single line text', { exact: true }).click();


Please run the entire test suite in order to identify conflicting tests. This is conflicting with adminPanelFormEditor.spec.ts -> change field heading.

We can either:

Update the older test to restore the original fieldname (this would be preferred, because it resolves a problem in that test)

OR update this test to remove exact: true

aerinkayne · 2024-11-26T19:00:43Z

These two fail for me if I re-run the test
Validate comment approval functionality and comment visibility on record page
Validate AND Logical Filter operators to generate report

…artment-of-veterans-affairs/LEAF-Automated-Tests into report-builder-testscenarios

nk2136 · 2024-11-26T20:41:53Z

…ios' into local branch

nk2136 · 2024-12-12T02:12:37Z

The tests have been fixed and the test names are updated. Tests are working as expected. Test #1 will still fail on the screenshot. But the remaining 14 which I worked is passing on every run. @mgaoVA @aerinkayne.

nk2136 added 6 commits October 16, 2024 15:26

added scenarios for reportBuilder

d32d5ed

moved package json and config files to root directory

07cf7cc

Update .gitignore to ignore node_modules, playwright-report, and test…

58be34b

…-results

Move .gitignore to root and update ignored files

9b933cb

Remove unnecessary files from end2end

da6c1ef

code clean up

23a0bc4

nk2136 added 4 commits October 17, 2024 14:12

moved config.ts and json file to new folder

c63fd16

added new test scenarios for report-builder

e67dd97

fix minor changes

d94f244

code clean up

2ee797e

Pelentan marked this pull request as ready for review October 24, 2024 13:32

Pelentan requested review from mgaoVA, Pelentan, aerinkayne, pete-nerantzinis, shaneodd, jampaul3 and KCN8 as code owners October 24, 2024 13:32

nk2136 added 4 commits October 24, 2024 08:56

resolve merge conflicts

e94b516

fix error on files

d1ef779

code clean up, update locator

468e21d

new pull

54dc7bb

mgaoVA requested changes Oct 25, 2024

View reviewed changes

nk2136 added 5 commits October 28, 2024 14:51

pr fixes- 2 left

8b84164

added instructions how to install playwright and run test

b14ef4d

changes as per pr review

73e08cf

pull latest

49a89a2

remove test.only

b0d6d06

mgaoVA reviewed Oct 31, 2024

View reviewed changes

mgaoVA marked this pull request as draft October 31, 2024 19:52

nk2136 added 5 commits November 5, 2024 13:54

Resolved merge conflicts and completed merge

28508e6

code refactor

683f865

code refactor

22721b5

Fix test names

faee39f

fix indentation

7cd6c7b

mgaoVA requested changes Nov 15, 2024

View reviewed changes

tests/reportBuilder.spec.ts

1bea3eb

nk2136 force-pushed the report-builder-testscenarios branch from 8aaca9a to 2c09773 Compare November 20, 2024 16:37

fixed pr comments feedbacks

e141f5d

nk2136 force-pushed the report-builder-testscenarios branch from 2c09773 to e141f5d Compare November 20, 2024 16:47

removed useracces group test and fixed the PR suggestions

10489ab

nk2136 marked this pull request as ready for review November 26, 2024 00:00

nk2136 added 2 commits November 25, 2024 23:51

Fix issue in test to ensure correct behavior

3482ccd

Fix issue in test to ensure correct behavior

22ec038

nk2136 force-pushed the report-builder-testscenarios branch from 3482ccd to 22ec038 Compare November 26, 2024 15:38

nk2136 added 2 commits November 26, 2024 13:56

Merge branch 'report-builder-testscenarios' of https://github.com/dep…

704ee77

…artment-of-veterans-affairs/LEAF-Automated-Tests into report-builder-testscenarios

Merge branch 'main' into report-builder-testscenarios

164bd3b

nk2136 added 4 commits November 28, 2024 11:52

fix the failed test

5869e81

Resolved merge conflicts and merged 'origin/report-builder-testscenar…

a5e4beb

…ios' into local branch

fix test

c4f0c63

Fix test names and correct test logic

534d10f

nk2136 closed this Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Report Builder Tests #6

Report Builder Tests #6

nk2136 commented Oct 16, 2024 •

edited

Loading

nk2136 commented Oct 17, 2024

mgaoVA Oct 25, 2024

nk2136 Nov 27, 2024

nk2136 commented Oct 29, 2024

mgaoVA Oct 31, 2024 •

edited

Loading

mgaoVA commented Oct 31, 2024 •

edited

Loading

mgaoVA Nov 14, 2024

nk2136 Nov 26, 2024

mgaoVA Nov 14, 2024

nk2136 Nov 25, 2024

mgaoVA Nov 14, 2024

mgaoVA Nov 14, 2024

mgaoVA Nov 14, 2024

nk2136 Nov 25, 2024

mgaoVA Nov 14, 2024

nk2136 Nov 25, 2024

mgaoVA Nov 14, 2024

nk2136 Nov 25, 2024

mgaoVA Nov 15, 2024

nk2136 Nov 26, 2024

mgaoVA Nov 15, 2024

nk2136 Nov 26, 2024

aerinkayne commented Nov 26, 2024

nk2136 commented Nov 26, 2024

nk2136 commented Dec 12, 2024

		await page.getByRole('button', { name: "Edit Labels" }).click();
		await page.getByRole('button', { name: 'Save Change' }).click();

	test('Modify search with AND logical filter', async ({ page }) => {
	test('Modify search with AND logical filter (UI only, does not validate filter results)', async ({ page }) => {

		});

		test("Select multiple filter using AND/OR,", async ({ page }) => {

	test("Select multiple filter using AND/OR,", async ({ page }) => {
	test('Select multiple filter using AND/OR (UI only, does not validate filter results)', async ({ page }) => {

Report Builder Tests #6

Report Builder Tests #6

Conversation

nk2136 commented Oct 16, 2024 • edited Loading

nk2136 commented Oct 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nk2136 commented Oct 29, 2024

mgaoVA Oct 31, 2024 • edited Loading

Choose a reason for hiding this comment

mgaoVA commented Oct 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aerinkayne commented Nov 26, 2024

nk2136 commented Nov 26, 2024

nk2136 commented Dec 12, 2024

nk2136 commented Oct 16, 2024 •

edited

Loading

mgaoVA Oct 31, 2024 •

edited

Loading

mgaoVA commented Oct 31, 2024 •

edited

Loading