LEAF-4487 - Large Queries #11
Conversation
shaneodd
requested review from
mgaoVA,
Pelentan,
aerinkayne,
pete-nerantzinis,
jampaul3,
nk2136 and
KCN8
as code owners
There was a problem hiding this comment.
These tests should be moved into the formQuery_test.go file, since it's testing api/form/query.
The test should not be made "compatible" with the master branch -- since we're looking for a specific header to determine success, the absence of the header must indicate failure. Explaining that the test only works with a specific PR (which you've already done) would be sufficient. Maybe we can also create a label in Github to highlight this distinction.
…when large query server/code is not in use
…he correct docker config and code, previus iterations allowed for passage if not run on the proper version since at the time we were unsure how the testing process would function
|
Updated the test to require the proper docker config and code to test and pass |
There was a problem hiding this comment.
I've added a requested change in department-of-veterans-affairs/LEAF#2546 to discuss simplification of the new header.
These tests are Ok, though can be strengthened by exercising all conditions of what defines a large query:
- No limit parameter set
- Limit is > 10,000 records
- Limit is > 1000 and <= 10,000 records AND more than 10 indicators are requested
Moving the test over here from the old x-test dir in leaf
This is the test that works with this pr, it should fail with the current master branch.
department-of-veterans-affairs/LEAF#2546