fix start networking.service before network is marked online #65
Conversation
|
try to guarantee this order below (from No. 3 to 5)
|
There was a problem hiding this comment.
Thank you for the explanation, and excuse my ignorance.
So DentOS ships ifupdown2 1.2.8.-1from some non-official package archive, as Debian 9 (stretch) only ships 1.0~git20170314-1. The systemd units are the same in the current version 3.0.0-1, and there are no similar bug reports in the Debian BTS.
The line
related to CumulusNetworks/ifupdown2#190
could be improved by using
Upstream ifupdown2 issue: CumulusNetworks/ifupdown2#190
I am always wondering, why such issues have not been reported for other environments yet.
As commented, I’d copy the ordering dependency from ifupdown, which is I guess better tested.
| @@ -1,2 +1,3 @@ | |||
| [Unit] | |||
| After=network-pre.target | |||
| After=local-fs.target network-pre.target | |||
There was a problem hiding this comment.
Instead of local-fs.target maybe use sysinit.target (bootup(7)), and remove the DefaultDependencies=no?
| @@ -1,2 +1,3 @@ | |||
| [Unit] | |||
| After=network-pre.target | |||
| After=local-fs.target network-pre.target | |||
| Before=shutdown.target network.target network-online.target | |||
There was a problem hiding this comment.
Maybe add to the commit message, that ifupdown is doing the same:
Requires=ifupdown-pre.service
Wants=network.target
After=local-fs.target network-pre.target apparmor.service systemd-sysctl.service systemd-modules-load.service ifupdown-pre.service
Before=network.target shutdown.target network-online.target
Conflicts=shutdown.target
There was a problem hiding this comment.
Yes, I just tried to follow ifupdown's config to setup this.
Thanks
I will add those commit message next time!
I talked to Cumulus engineer which is maintainer of ifupdown2 directly and didn't send this issue to BTS. It seems some users just report it to upstream repo instead of BTS.
Thanks for advice
I'm not sure we should take all service dependencies from ifupdown2 or not. Thanks for those advice! |
ifupdown2 didn't ensure that it will start before network.target and network-online.target. after local-fs.target because ifupdown2 need to read config file from local filesystem Other network services will not start after networking.service and fail because no interface is up. (e.g isc-dhcp-server, tftp-hpa) Signed-off-by: Date Huang <[email protected]>
taraschornyiplv
force-pushed
the
ifupdown2_order
branch
from
81d46be to
a99741d
Compare
|
This issue has been fixed in upstream CumulusNetworks/ifupdown2#190 |
|
Is this still needed? If yes, it needs to be updated for buster. |
ifupdown2 didn't ensure that it will start before network.target and network-online.target.
after local-fs.target because ifupdown2 need to read config file from local filesystem
Other network services will not start after networking.service and fail because no interface is up.
(e.g isc-dhcp-server, tftp-hpa)
related to #56
related to CumulusNetworks/ifupdown2#190
Signed-off-by: Date Huang [email protected]