Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README, mod.ts): update code example #33

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

otogawakatsutoshi
Copy link
Contributor

The explanation of how to use mod.ts and READEME is outdated.
When I look at the implementation of the source code, I see getCrossOption, I see OsRecord, and I see a test called download_test.ts,
It does not expect the string "unix" to come in.

OsRecord is defined as below, though,

type OsRecord<T> = { [os in typeof Deno.build.os]: T };

When I look at https://deno.land/[email protected]?s=Deno.build of the document, the definition of "unix" is not present.
"unix" should be changed to linux.

Copy link
Member

@eliassjogreen eliassjogreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the choice to write UNIX instead of Linux as there are multiple more non-linux posix compliant OSses but it might make more sense just to write Linux as to not confuse people.

@eliassjogreen eliassjogreen merged commit d8fabff into denosaurs:main Oct 3, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants