Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method to get subset of resolution snapshot #73

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

nathanwhit
Copy link
Member

Adds a subset method to NpmResolutionSnapshot, to get a subset of the snapshot rooted by some PackageReqs.

@nathanwhit nathanwhit requested a review from dsherret November 27, 2024 18:01
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. I think we should not return an Option.

src/resolution/snapshot.rs Outdated Show resolved Hide resolved
src/resolution/snapshot.rs Outdated Show resolved Hide resolved
src/resolution/snapshot.rs Outdated Show resolved Hide resolved
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM!

@nathanwhit nathanwhit merged commit cd4f3a4 into main Nov 29, 2024
1 check passed
@nathanwhit nathanwhit deleted the snapshot-subset branch December 5, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants