Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove concept of pending resolution #57

Merged
merged 6 commits into from
Jun 10, 2024
Merged

refactor: remove concept of pending resolution #57

merged 6 commits into from
Jun 10, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jun 6, 2024

No longer necessary because we resolve from deno_graph in a batch. This will simplify things.

I'll integrate this in the CLI before marking this as ready.

@dsherret
Copy link
Member Author

dsherret commented Jun 6, 2024

Huh, just rediscovered why it was done this way. I'll do a separate PR outlining why this is done.

@dsherret dsherret closed this Jun 6, 2024
@dsherret dsherret deleted the refactor_remove_pending branch June 6, 2024 21:48
@dsherret dsherret restored the refactor_remove_pending branch June 6, 2024 23:01
@dsherret
Copy link
Member Author

dsherret commented Jun 6, 2024 •
edited
Loading

Actually, this makes sense. We just need to return back a result for each specifier and a result for the total npm install. Then we need to store the npm install error in the graph probably. This will help enable dynamic imports of npm specifiers to fail individually.

@dsherret dsherret reopened this Jun 6, 2024
@dsherret dsherret marked this pull request as ready for review June 10, 2024 22:36
@dsherret dsherret mentioned this pull request Jun 10, 2024
Merged
bartlomieju
bartlomieju approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit bcba276 into denoland:main Jun 10, 2024
1 check passed
@dsherret dsherret deleted the refactor_remove_pending branch June 10, 2024 23:29
dsherret added a commit to denoland/deno that referenced this pull request Jun 11, 2024
@dsherret
fix(npm): resolve dynamic npm imports individually (#24170)
4bc96c5 
* denoland/deno_npm#57
* denoland/deno_graph#498

Closes #17802
nathanwhit pushed a commit to denoland/deno that referenced this pull request Jun 13, 2024
@dsherret @nathanwhit
fix(npm): resolve dynamic npm imports individually (#24170)
7cf15a4 
* denoland/deno_npm#57
* denoland/deno_graph#498

Closes #17802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju