Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore invalid values in npm registry JSON #53

Merged
merged 2 commits into from
May 17, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented May 17, 2024

For denoland/deno#23862

> deno run --reload index.ts
error: failed reading lockfile 'V:\scratch\deno.lock'

Caused by:
    Error getting response at https://registry.npmjs.org/urllib for package "urllib": invalid type: map, expected a string at line 1 column 24565
> ../deno/target/debug/deno run --reload index.ts
┌ ⚠️  Deno requests env access.
├ Run again with --allow-env to bypass this prompt.
└ Allow? [y/n/A] (y = yes, allow; n = no, deny; A = allow all env permissions) >

@dsherret dsherret requested a review from bartlomieju May 17, 2024 15:20
@dsherret dsherret changed the title fix: handle invalid values in npm registry JSON fix: ignore invalid values in npm registry JSON May 17, 2024
@dsherret dsherret merged commit 6634252 into denoland:main May 17, 2024
1 check passed
@dsherret dsherret deleted the fix_deserialization_npm_registry branch May 17, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants