refactor: export variables for better consumption from the outside #27189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow others to consume how far Deno is from a compatibility-perspective. Signed-off-by: Mathias Lykkegaard Lorenzen <[email protected]>
|
|
kt3k
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
LGTM
BTW we are planning to make these changes in some future. In that case, getDenoTests becomes an async function.
|
@kt3k sounds fine to me. Although this will essentially make these functions a "public API", I am fine with it breaking. We could maybe just keep it "as-is". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow others to consume how far Deno is from a compatibility-perspective.
Here's a discussion: #26745
From that, I made this site: https://ffmathy.github.io/is-deno-compatible-yet/
But it is showing the wrong calculations. Exposing these fields would make it easy for me to "piggyback" on the right numbers.