chore: update hickory dns crates #27137
Open
+217
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that `thiserror` has gone from 1.x to 2.x. I have updated this repo to 2.x (hickory is using 2.x now). We will need to migrate over all of our `deno_*` dependencies to also use 2.x at some point. We also have 5 or 6 third party dependencies that have dependencies on `thiserror 1.x`. This will likely haunt us for a while still.
bartlomieju
approved these changes
Nov 28, 2024
djc
approved these changes
Nov 29, 2024
| { | ||
| NetError::DnsNotFound(e) | ||
| } | ||
| ResolveErrorKind::Proto(ProtoError { kind, .. }) |
There was a problem hiding this comment.
I agree that this is the correct change -- in fact, the previous version of the match arm (for ResolveErrorKind::Message("No connections available"), originally from 25771b3) hasn't been effective for a while now (a NoConnections variant, first in ResolveErrorKind, now in ProtoErrorKind, has been around since trust-dns-resolver 0.21, from Feb 2022).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
thiserrorhas gone from 1.x to 2.x. I have updated this repo to 2.x (hickory is using 2.x now). We will need to migrate over all of ourdeno_*dependencies to also use 2.x at some point. We also have 5 or 6 third party dependencies that have dependencies onthiserror 1.x. This will likely haunt us for a while still.