Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node/timers): error when passing id to clearTimeout/clearInterval #27130

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix(node/timers): error when passing id to clearTimeout/clearInterval #27130

merged 1 commit into from
Nov 28, 2024

Conversation

marvinhagemeister
Copy link
Contributor

As pointed out in #27126 we used a variable which could potentially be of type number instead of the Timeout class instance. Ensure that we're always setting _destroyed on the class instead instead.

Fixes #27126

@marvinhagemeister marvinhagemeister merged commit 39722f1 into main Nov 28, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the fix-node-timer-clear branch November 28, 2024 14:11
bartlomieju pushed a commit that referenced this pull request Nov 28, 2024
@marvinhagemeister @bartlomieju
fix(node/timers): error when passing id to clearTimeout/clearInterval (…
da64aa9 
…#27130)

As pointed out in #27126 we used
a variable which could potentially be of type `number` instead of the
`Timeout` class instance. Ensure that we're always setting `_destroyed`
on the class instead instead.

Fixes #27126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with node:timers for clearTimeout
2 participants
@marvinhagemeister @bartlomieju