Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): tls.connect socket upgrades #27125

Merged
merged 5 commits into from
Nov 28, 2024
Merged

fix(ext/node): tls.connect socket upgrades #27125

merged 5 commits into from
Nov 28, 2024

Conversation

littledivy
Copy link
Member

Fixes #27087
Fixes #26685
Fixes #26660

lucacasonato
lucacasonato approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@littledivy littledivy merged commit 1af2d24 into denoland:main Nov 28, 2024
17 checks passed
bartlomieju pushed a commit that referenced this pull request Nov 28, 2024
@littledivy @bartlomieju
fix(ext/node): tls.connect socket upgrades (#27125)
52bcd35 
Fixes #27087
Fixes #26685
Fixes #26660
@LP1994
Copy link

LP1994 commented Nov 29, 2024

Thank you!
I found the problem mentioned in 26660 from about 2023, but at that time, I checked for a long time and thought it would be solved in deno 2.0, so I waited for the release of 2.0. But then it was released, but it still didn't solve the 26660 problem, so I mentioned this 26660 problem report, and to my surprise, it was solved so quickly! Thanks so much! Kudos to you!

@LP1994
Copy link

LP1994 commented Nov 30, 2024

Fixes #27087 Fixes #26685 Fixes #26660

I just updated “deno” to “deno-2.1.2” and found that this problem (#26660) is still there.
image
image
MongodB log:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@littledivy @LP1994 @lucacasonato @bartlomieju