chore: add script to check remaining node compat cases #27122
+217
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
added a commit
that referenced
this pull request
Dec 4, 2024
This PR enables node compat test cases found passing by using the tool added in #27122 The percentage of passing test case increases from 16.16% to 30.43% by this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script to check the remaining node compat test cases. (
challenge_new_test.ts)The script copies the remaining test case from vendored node.js test files, and run and check the result one by one. It reports the passing test cases at the end.
This PR also slightly changes how to count the 'remaining' cases. Now we exclude the items in
ignoresection ofconfig.jsoncbecause these test cases are somehow executed with some manual modification on our side (They are only ignored in 'copying' process). This changes ported test percentage from 16.16% to 17.33%.The addition of actual test cases found by this script will follow this PR.