Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/canvas): enhance createImageBitmap specification compliance #25517

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

feat(ext/canvas): enhance createImageBitmap specification compliance #25517

wants to merge 56 commits into from
+1,826 −308

Commits on Aug 29, 2024

  1. basic support all image type pattern of unsigned 8bit when its blob e… 

    …xcept for JPG and animated image

- https://mimesniff.spec.whatwg.org/#matching-an-image-type-pattern
    @Hajime-san
    Hajime-san committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    198c90a View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. support 8bit JPG

    @Hajime-san
    Hajime-san committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    b9fe5e8 View commit details
    Browse the repository at this point in the history

  2. handling unsuportted situation 

    - adding `DOMExceptionInvalidStateError` in global due to handling not supported image format
- animation image is not supported currently
    @Hajime-san
    Hajime-san committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    77703e8 View commit details
    Browse the repository at this point in the history

  3. fmt

    @Hajime-san
    Hajime-san committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    22cf2f9 View commit details
    Browse the repository at this point in the history

  4. cleanup premultiplyAlpha and adding test

    @Hajime-san
    Hajime-san committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    32d71f5 View commit details
    Browse the repository at this point in the history

  5. handling unsupported bit depth

    @Hajime-san
    Hajime-san committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    827e7b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. port to rust

    @Hajime-san
    Hajime-san committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0de8a9b View commit details
    Browse the repository at this point in the history

  2. support animated PNG

    @Hajime-san
    Hajime-san committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d0da79e View commit details
    Browse the repository at this point in the history

  3. support animated WebP

    @Hajime-san
    Hajime-san committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d255518 View commit details
    Browse the repository at this point in the history

  4. support animated GIF

    @Hajime-san
    Hajime-san committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    396c09c View commit details
    Browse the repository at this point in the history

  5. support colorspaceConversion for ImageData

    @Hajime-san
    Hajime-san committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7d3e39d View commit details
    Browse the repository at this point in the history

  6. support colorspaceConversion for Blob

    @Hajime-san
    Hajime-san committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a6604c1 View commit details
    Browse the repository at this point in the history

  7. clean up unit test

    @Hajime-san
    Hajime-san committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1e21467 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. clean up

    @Hajime-san
    Hajime-san committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    1f7524a View commit details
    Browse the repository at this point in the history

  2. add unit test

    @Hajime-san
    Hajime-san committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    98e9304 View commit details
    Browse the repository at this point in the history

  3. update README

    @Hajime-san
    Hajime-san committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    4bc517e View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into update-imagebitmap

    @Hajime-san
    Hajime-san committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    dbac50d View commit details
    Browse the repository at this point in the history

  5. fix error handling

    @Hajime-san
    Hajime-san committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    f0895c6 View commit details
    Browse the repository at this point in the history

  6. update README

    @Hajime-san
    Hajime-san committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    86f0000 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. revert "support colorspaceConversion for ImageData"

    @Hajime-san
    Hajime-san committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    75d26df View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. switch to static link for lcms2

    @Hajime-san
    Hajime-san committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    1de527f View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge branch 'main' into update-imagebitmap

    @Hajime-san
    Hajime-san authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    825515e View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. add comments for the reference of image mimesniff

    @Hajime-san
    Hajime-san committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    bd77fb9 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. clean up process_icc_profile_conversion

    @Hajime-san
    Hajime-san committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    2d58fd1 View commit details
    Browse the repository at this point in the history

  2. clean up

    @Hajime-san
    Hajime-san committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    d258914 View commit details
    Browse the repository at this point in the history

  3. fmt

    @Hajime-san
    Hajime-san committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    fa01320 View commit details
    Browse the repository at this point in the history

  4. avoid copying vector

    @Hajime-san
    Hajime-san committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    8d8d726 View commit details
    Browse the repository at this point in the history

  5. image_ops takes responsibility of treat alpha channel

    @Hajime-san
    Hajime-san committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    fc4064e View commit details
    Browse the repository at this point in the history

  6. avoid copying string

    @Hajime-san
    Hajime-san committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    fb6b87d View commit details
    Browse the repository at this point in the history

  7. perf: return the value not a struct but a tuple

    @Hajime-san
    Hajime-san committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    3beb65b View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. add unit test for imageOrientation

    @Hajime-san
    Hajime-san committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    829f523 View commit details
    Browse the repository at this point in the history

  2. add comments for the reference of issues about imageOrientation

    @Hajime-san
    Hajime-san committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9a9664e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into update-imagebitmap

    @Hajime-san
    Hajime-san committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f3aa376 View commit details
    Browse the repository at this point in the history

  4. update error message

    @Hajime-san
    Hajime-san committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    5e52b86 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. handle 32-bit depth

    @Hajime-san
    Hajime-san committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    1b545f9 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. clean up

    @Hajime-san
    Hajime-san committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    977026c View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. fix

    @Hajime-san
    Hajime-san committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    69addc8 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. perf: pass u8 to op

    @Hajime-san
    Hajime-san committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    acc4119 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. support imageOrientation correctly

    @Hajime-san
    Hajime-san committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    83c40c4 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary boilerplate

    @Hajime-san
    Hajime-san committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    cb72235 View commit details
    Browse the repository at this point in the history

  3. add comment

    @Hajime-san
    Hajime-san committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    3ef4cf9 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Merge branch 'main' into update-imagebitmap

    @Hajime-san
    Hajime-san committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    529c3f0 View commit details
    Browse the repository at this point in the history

  2. update error

    @Hajime-san
    Hajime-san committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    50bee86 View commit details
    Browse the repository at this point in the history

  3. map lcms error

    @Hajime-san
    Hajime-san committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1429013 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. remove TODO 

    - denoland#25517 (comment)
    @Hajime-san
    Hajime-san committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    40c89cc View commit details
    Browse the repository at this point in the history

  2. move suggestion to runtime/format_errors.rs 

    - denoland#25517 (comment)
- denoland#25517 (comment)
    @Hajime-san
    Hajime-san committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ad67750 View commit details
    Browse the repository at this point in the history

  3. remove comment out 

    - denoland#25517 (comment)
    @Hajime-san
    Hajime-san committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    3fcc3ab View commit details
    Browse the repository at this point in the history

  4. remove comment 

    - denoland#25517 (comment)
    @Hajime-san
    Hajime-san committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    24306b3 View commit details
    Browse the repository at this point in the history

  5. remove boilerplate 

    - denoland#25517 (comment)
    @Hajime-san
    Hajime-san committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    332fc41 View commit details
    Browse the repository at this point in the history

  6. use an unique variant of CanvasError 

    - denoland#25517 (comment)
    @Hajime-san
    Hajime-san committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d764f62 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. implement the case of ImageBitmap 

    - denoland#25517 (comment)
    @Hajime-san
    Hajime-san committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    4b9cf86 View commit details
    Browse the repository at this point in the history

  2. better error handling

    @Hajime-san
    Hajime-san committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    5b11282 View commit details
    Browse the repository at this point in the history

  3. fix typo

    @Hajime-san
    Hajime-san committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    e59be4a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into update-imagebitmap

    @Hajime-san
    Hajime-san committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    40cee98 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. use ImageError instead of string 

    - denoland#25517 (comment)
    @Hajime-san
    Hajime-san committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    7039401 View commit details
    Browse the repository at this point in the history

  2. align error message 

    - denoland#25517 (comment)
    @Hajime-san
    Hajime-san committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    4cca9ae View commit details
    Browse the repository at this point in the history