bump: [email protected] (#225)

* bump: Upgrade deno to v1.9.0
* fix: Fix lint errors
* fix: Use std/io/buffer instead of Deno.Buffer
* fix: Use std/io/util instead of Deno.readAll and writeAll

.denov

@@ -1 +1 @@
-v1.8.2
+v1.9.0

.github/workflows/build.yml

@@ -39,8 +39,8 @@ jobs:
 
       - name: Run lint
         run: |
-          deno fmt --check
-          deno lint --unstable
+          deno fmt --check --ignore=./benchmark/node_modules
+          deno lint --unstable --ignore=./benchmark/node_modules
 
       - name: Set up Redis ${{ matrix.redis }}
         uses: shogo82148/actions-setup-redis@v1

connection.ts

@@ -140,13 +140,13 @@ export class RedisConnection implements Connection {
     try {
       await sendCommand(this.writer, this.reader, "PING");
       this._isConnected = true;
-    } catch (error) {
+    } catch (_error) { // TODO: Maybe we should log this error.
       this._isConnected = false;
       return new Promise((resolve, reject) => {
-        const interval = setInterval(async () => {
+        const _interval = setInterval(async () => {
           if (this.retryCount > this.maxRetryCount) {
             this.close();
-            clearInterval(interval);
+            clearInterval(_interval);
             reject(new Error("Could not reconnect"));
           }
           try {
@@ -155,9 +155,9 @@ export class RedisConnection implements Connection {
             await sendCommand(this.writer, this.reader, "PING");
             this._isConnected = true;
             this.retryCount = 0;
-            clearInterval(interval);
+            clearInterval(_interval);
             resolve();
-          } catch (err) {
+          } catch (_err) {
             // retrying
           } finally {
             this.retryCount++;

modules-lock.json

@@ -1,11 +1,13 @@
 {
   "https://deno.land/std": {
-    "version": "@0.91.0",
+    "version": "@0.93.0",
     "modules": [
       "/async/mod.ts",
       "/testing/bench.ts",
       "/testing/asserts.ts",
+      "/io/buffer.ts",
       "/io/bufio.ts",
+      "/io/util.ts",
       "/fmt/colors.ts"
     ]
   }

modules.json

@@ -1,11 +1,13 @@
 {
   "https://deno.land/std": {
-    "version": "@0.91.0",
+    "version": "@0.93.0",
     "modules": [
       "/async/mod.ts",
       "/testing/bench.ts",
       "/testing/asserts.ts",
+      "/io/buffer.ts",
       "/io/bufio.ts",
+      "/io/util.ts",
       "/fmt/colors.ts"
     ]
   }

protocol/reply.ts

@@ -1,4 +1,5 @@
 import { BufReader } from "../vendor/https/deno.land/std/io/bufio.ts";
+import { Buffer } from "../vendor/https/deno.land/std/io/buffer.ts";
 import type * as types from "./types.ts";
 import { EOFError, ErrorReplyError, InvalidStateError } from "../errors.ts";
 import { decoder } from "./_util.ts";
@@ -218,7 +219,7 @@ async function readLine(reader: BufReader): Promise<string> {
       if (d1 === "\n".charCodeAt(0)) {
         buf[loc++] = d;
         buf[loc++] = d1;
-        return decoder.decode(new Deno.Buffer(buf.subarray(0, loc)).bytes());
+        return decoder.decode(new Buffer(buf.subarray(0, loc)).bytes());
       }
     }
     buf[loc++] = d;

redis.ts

@@ -45,19 +45,16 @@ import type { RedisConnectionOptions } from "./connection.ts";
 import { CommandExecutor, MuxExecutor } from "./executor.ts";
 import { unwrapReply } from "./protocol/mod.ts";
 import type {
-  ArrayReply,
   Binary,
   Bulk,
   BulkNil,
   BulkReply,
   BulkString,
   ConditionalArray,
   Integer,
-  IntegerReply,
   Raw,
   RedisValue,
   SimpleString,
-  SimpleStringReply,
 } from "./protocol/mod.ts";
 import { createRedisPipeline } from "./pipeline.ts";
 import { psubscribe, subscribe } from "./pubsub.ts";
@@ -1465,7 +1462,7 @@ export class RedisImpl implements Redis {
       args.push("MINMATCHLEN");
       args.push(opts.minmatchlen);
     }
-    return this.execBulkReply("STRALGO", "LCS", target, a, b, ...args);
+    return this.execBulkReply("STRALGO", algorithm, target, a, b, ...args);
   }
 
   strlen(key: string) {

tests/acl_test.ts

@@ -133,7 +133,7 @@ suite.test("log", async () => {
   const randString = "balh";
   try {
     await client.auth(randString, randString);
-  } catch (error) {
+  } catch (_error) {
     // skip invalid username-password pair error
   }
   assertEquals((await client.aclLog(1))[0][9], randString);

tests/connection_test.ts

@@ -1,5 +1,4 @@
-import { connect, Redis } from "../mod.ts";
-import { delay } from "../vendor/https/deno.land/std/async/mod.ts";
+import { connect } from "../mod.ts";
 import { assertEquals } from "../vendor/https/deno.land/std/testing/asserts.ts";
 import {
   newClient,

tests/executor_test.ts

@@ -1,9 +1,5 @@
-import { BulkReply, ErrorReplyError, parseURL, replyTypes } from "../mod.ts";
-import {
-  assert,
-  assertEquals,
-  assertThrowsAsync,
-} from "../vendor/https/deno.land/std/testing/asserts.ts";
+import { BulkReply, replyTypes } from "../mod.ts";
+import { assertEquals } from "../vendor/https/deno.land/std/testing/asserts.ts";
 import {
   newClient,
   nextPort,

tests/general_test.ts

@@ -1,6 +1,5 @@
 import { ErrorReplyError, parseURL } from "../mod.ts";
 import {
-  assert,
   assertEquals,
   assertThrowsAsync,
 } from "../vendor/https/deno.land/std/testing/asserts.ts";

tests/script_test.ts

@@ -1,5 +1,3 @@
-import { connect, Redis } from "../mod.ts";
-import { delay } from "../vendor/https/deno.land/std/async/mod.ts";
 import {
   assert,
   assertEquals,

tests/stream_test.ts

@@ -123,7 +123,7 @@ suite.test("xread", async () => {
   assert(a != null);
   const key2 = randomStream();
 
-  const b = await client.xadd(
+  await client.xadd(
     key2,
     [1000, 0], // You may enter the ID as a numeric pair
     { air: "ball", friend: "table" },

tools/make_mod.ts

@@ -1,5 +1,7 @@
 #!/usr/bin/env deno run --allow-read --allow-write --allow-run
 
+import { readAll, writeAll } from "../vendor/https/deno.land/std/io/util.ts";
+
 const encoder = new TextEncoder();
 const decoder = new TextDecoder();
 
@@ -14,7 +16,7 @@ async function doc(fileName: string): Promise<Array<Node>> {
     stdout: "piped",
   });
   try {
-    const out = await Deno.readAll(deno.stdout);
+    const out = await readAll(deno.stdout);
     return JSON.parse(decoder.decode(out));
   } finally {
     deno.stdout.close();
@@ -29,9 +31,9 @@ async function fmt(content: string): Promise<string> {
     stdout: "piped",
   });
   try {
-    await Deno.writeAll(deno.stdin, encoder.encode(content));
+    await writeAll(deno.stdin, encoder.encode(content));
     deno.stdin.close();
-    const formattedContent = decoder.decode(await Deno.readAll(deno.stdout));
+    const formattedContent = decoder.decode(await readAll(deno.stdout));
     return formattedContent;
   } finally {
     deno.stdout.close();

vendor/https/deno.land/std/async/mod.ts

@@ -1 +1 @@
-export * from "https://deno.land/std@0.91.0/async/mod.ts";
+export * from "https://deno.land/std@0.93.0/async/mod.ts";

vendor/https/deno.land/std/fmt/colors.ts

@@ -1 +1 @@
-export * from "https://deno.land/std@0.91.0/fmt/colors.ts";
+export * from "https://deno.land/std@0.93.0/fmt/colors.ts";

vendor/https/deno.land/std/io/buffer.ts

@@ -0,0 +1 @@
+export * from "https://deno.land/[email protected]/io/buffer.ts";

vendor/https/deno.land/std/io/bufio.ts

@@ -1 +1 @@
-export * from "https://deno.land/std@0.91.0/io/bufio.ts";
+export * from "https://deno.land/std@0.93.0/io/bufio.ts";

vendor/https/deno.land/std/io/util.ts

@@ -0,0 +1 @@
+export * from "https://deno.land/[email protected]/io/util.ts";

vendor/https/deno.land/std/testing/asserts.ts

@@ -1 +1 @@
-export * from "https://deno.land/std@0.91.0/testing/asserts.ts";
+export * from "https://deno.land/std@0.93.0/testing/asserts.ts";

vendor/https/deno.land/std/testing/bench.ts

@@ -1 +1 @@
-export * from "https://deno.land/std@0.91.0/testing/bench.ts";
+export * from "https://deno.land/std@0.93.0/testing/bench.ts";