fix: RangeError handling

denodrivers · Oct 23, 2023 · 320e1a7 · 320e1a7
1 parent b44a3a2
commit 320e1a7
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/internal/buffered_readable_stream.ts b/internal/buffered_readable_stream.ts
@@ -36,7 +36,7 @@ export class BufferedReadableStream {
 
   async readFull(buffer: Uint8Array): Promise<void> {
     if (buffer.length <= this.#buffer.length) {
-      buffer.set(this.#buffer);
+      buffer.set(this.#buffer.subarray(0, buffer.length));
       this.#buffer = this.#buffer.subarray(buffer.length);
       return;
     }

diff --git a/internal/buffered_readable_stream_test.ts b/internal/buffered_readable_stream_test.ts
@@ -1,3 +1,4 @@
+import { encoder } from "../protocol/_util.ts";
 import {
   assertEquals,
   assertFalse,
@@ -62,6 +63,37 @@ Deno.test({
 
       assertFalse(readable.locked);
     });
+
+    await t.step(
+      "`readFull` should not throw `RangeError: offset is out of bounds` error",
+      async () => {
+        const readable = new ReadableStream<Uint8Array>({
+          start(controller) {
+            controller.enqueue(encoder.encode("foobar"));
+            controller.close();
+          },
+        });
+        const buffered = new BufferedReadableStream(readable);
+        {
+          const buf = new Uint8Array(3);
+          await buffered.readFull(buf);
+          assertEquals(decoder.decode(buf), "foo");
+        }
+
+        {
+          const buf = new Uint8Array(1);
+          await buffered.readFull(buf);
+          assertEquals(decoder.decode(buf), "b");
+        }
+
+        await buffered.readFull(new Uint8Array(0));
+        {
+          const buf = new Uint8Array(2);
+          await buffered.readFull(buf);
+          assertEquals(decoder.decode(buf), "ar");
+        }
+      },
+    );
   },
 });