chore: RedisSubscriptionImpl should not mutate Connection.maxRetryCou…

…nt directly (#159)
denodrivers · Dec 4, 2020 · 11b1b2c · 11b1b2c
1 parent 0260475
commit 11b1b2c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/connection.ts b/connection.ts
@@ -10,9 +10,11 @@ export interface Connection {
   retryInterval: number;
   isClosed: boolean;
   isConnected: boolean;
+  isRetriable: boolean;
   close(): void;
   connect(): Promise<void>;
   reconnect(): Promise<void>;
+  forceRetry(): void;
 }
 
 export type RedisConnectionOptions = {
@@ -45,6 +47,10 @@ export class RedisConnection implements Connection {
     return this._isConnected;
   }
 
+  get isRetriable(): boolean {
+    return this.maxRetryCount > 0;
+  }
+
   constructor(
     hostname: string,
     port: number | string,
@@ -160,6 +166,10 @@ export class RedisConnection implements Connection {
       });
     }
   }
+
+  forceRetry(): void {
+    this.maxRetryCount = 10; // TODO Adjust this.
+  }
 }
 
 function parsePortLike(port: string | number | undefined): number {

diff --git a/pubsub.ts b/pubsub.ts
@@ -32,7 +32,7 @@ class RedisSubscriptionImpl implements RedisSubscription {
 
   constructor(private connection: Connection) {
     // Force retriable connection for connection shared for pub/sub.
-    if (connection.maxRetryCount === 0) connection.maxRetryCount = 10;
+    if (!connection.isRetriable) connection.forceRetry();
   }
 
   async psubscribe(...patterns: string[]) {