Skip to content

Commit

Permalink
chore: add missing return types (#447)
Browse files Browse the repository at this point in the history
  • Loading branch information
iuioiua authored Feb 5, 2024
1 parent 51e34b2 commit d7a8b0c
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export abstract class QueryClient {
this.#connection = connection;
}

get connected() {
get connected(): boolean {
return this.#connection.connected;
}

Expand Down
6 changes: 3 additions & 3 deletions connection/connection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,17 +128,17 @@ export class Connection {
#tls?: boolean;
#transport?: "tcp" | "socket";

get pid() {
get pid(): number | undefined {
return this.#pid;
}

/** Indicates if the connection is carried over TLS */
get tls() {
get tls(): boolean | undefined {
return this.#tls;
}

/** Indicates the connection protocol used */
get transport() {
get transport(): "tcp" | "socket" | undefined {
return this.#transport;
}

Expand Down
2 changes: 1 addition & 1 deletion query/query.ts
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export class QueryResult {
#row_description?: RowDescription;
public warnings: Notice[] = [];

get rowDescription() {
get rowDescription(): RowDescription | undefined {
return this.#row_description;
}

Expand Down
6 changes: 3 additions & 3 deletions query/transaction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class Savepoint {
this.#update_callback = update_callback;
}

get instances() {
get instances(): number {
return this.#instance_count;
}

Expand Down Expand Up @@ -142,11 +142,11 @@ export class Transaction {
this.#updateClientLock = update_client_lock_callback;
}

get isolation_level() {
get isolation_level(): IsolationLevel {
return this.#isolation_level;
}

get savepoints() {
get savepoints(): Savepoint[] {
return this.#savepoints;
}

Expand Down

1 comment on commit d7a8b0c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No typecheck tests failure

This error was most likely caused by incorrect type stripping from the SWC crate

Please report the following failure to https://github.com/denoland/deno with a reproduction of the current commit

Failure log

Please sign in to comment.