-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run e2e tests in docker #4563
base: main
Are you sure you want to change the base?
Run e2e tests in docker #4563
Conversation
- use appropriate UID & GID - reduce data on image - avoid unneeded data in working dir
01b985d
to
ddad229
Compare
you could also do:
|
# add a user "noone" with the same uid and gid as the host user | ||
RUN groupadd -g $gid -o noone | ||
RUN useradd -ms /bin/bash -u $uid -g $gid noone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that this now doesn't override node_modules
. Very nice. But still, what files does this write? Why do we need this? Is this the HTML report file that Playwright generates? Wouldn't it be better to keep it in the container instead of writing to host? Using the outputFolder
option.
Reduced Dockerfile
Use only Chrome as playwright project to reduce test duration: