feat: delete_msgs: Use transaction() instead of call_write() #6363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
commented
Dec 23, 2024
| @@ -707,9 +707,6 @@ pub(crate) async fn save( | |||
| ))?; | |||
|
|
|||
| if timestamp > newest_timestamp { | |||
| // okay to drop, as we use cached prepared statements | |||
There was a problem hiding this comment.
These are auto-dropped at the end of the scope anyway
link2xt
approved these changes
Dec 23, 2024
src/message.rs
Outdated
| @@ -1613,15 +1613,15 @@ pub async fn delete_msgs(context: &Context, msg_ids: &[MsgId]) -> Result<()> { | |||
| modified_chat_ids.insert(msg.chat_id); | |||
|
|
|||
| let target = context.get_delete_msgs_target().await?; | |||
| let update_db = |conn: &mut rusqlite::Connection| { | |||
| let update_db = |conn: &mut rusqlite::Transaction| { | |||
There was a problem hiding this comment.
I'd rename conn to transaction.
There was a problem hiding this comment.
Transaction implements Deref<Target = Connection>, so maybe conn is also ok, but renamed it to trans
Explicit transaction does the only commit (and fsync()).
iequidoo
force-pushed
the
iequidoo/use-transaction
branch
from
4cc796b to
0efd7cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit transaction does the only commit (and fsync()).
Checked other usages of
call_write(), it seems in other places it doesn't make sense or isn't possible to usetransaction().