fix: reduce number of repeat_vars() calls #6358
Merged
+75
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
reviewed
Dec 22, 2024
link2xt
force-pushed
the
link2xt/no-repeat-vars
branch
3 times, most recently
from
e841601 to
0550ef3
Compare
iequidoo
approved these changes
Dec 22, 2024
link2xt
force-pushed
the
link2xt/no-repeat-vars
branch
from
0550ef3 to
feecaa5
Compare
SQL statements fail if the number of variables exceeds `SQLITE_LIMIT_VARIABLE_NUMBER`. Remaining repeat_vars() calls are difficult to replace and use arrays passed from the UI, e.g. forwarded message IDs or marked as seen IDs.
link2xt
force-pushed
the
link2xt/no-repeat-vars
branch
from
feecaa5 to
78e0b19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL statements fail if the number of variables
exceeds
SQLITE_LIMIT_VARIABLE_NUMBER.Remaining repeat_vars() calls are difficult to replace
and use arrays passed from the UI,
e.g. forwarded message IDs or marked as seen IDs.
Closes #6355