fix: Change BccSelf default to 0 for chatmail (#6340) #6344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
commented
Dec 17, 2024
src/config.rs
Outdated
| Config::ConfiguredInboxFolder => Some("INBOX"), | ||
| Config::DeleteServerAfter => { | ||
| match Box::pin(self.get_config(Config::BccSelf)).await?.as_deref() { | ||
| Some("0") => Some("1"), |
There was a problem hiding this comment.
A check for IsChatmail is forgotten
There was a problem hiding this comment.
Though it's an interesting question -- is leaving emails on the server useful w/o BccSelf? Probably not for most email providers because outgoing messages would be missing anyway. But to keep the current behaviour a check for IsChatmail should be added. Also other MUAs don't delete emails from the server by default even if the server doesn't save sent messages to some sentbox (like Gmail does)
EDIT: Fixed and added a test on the default DeleteServerAfter behaviour.
Change `BccSelf` default to 0 for chatmail configurations and enable it upon a backup export. As for `DeleteServerAfter` who was set to 0 upon a backup export before, make its default dependent on `BccSelf` for chatmail. We don't need `BccSelf` for chatmail by default because we assume single-device use. Also `BccSelf` is needed for "classic" email accounts even if `DeleteServerAfter` is set to "immediately" to detect that a message was sent if SMTP server is slow to respond and connection is lost before receiving the status line which isn't a problem for chatmail servers.
iequidoo
force-pushed
the
iequidoo/0-bcc_self-for-chatmail
branch
from
dc4dcf4 to
a900800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6340