feat: cache HTTP GET requests #6327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/http-cache
branch
2 times, most recently
from
deb2de0 to
42b9a96
Compare
link2xt
force-pushed
the
link2xt/http-cache
branch
from
42b9a96 to
6cba9ab
Compare
hpk42
reviewed
Dec 11, 2024
link2xt
force-pushed
the
link2xt/http-cache
branch
from
65999cc to
b13bd75
Compare
hpk42
reviewed
Dec 11, 2024
hpk42
reviewed
Dec 11, 2024
hpk42
reviewed
Dec 11, 2024
iequidoo
approved these changes
Dec 11, 2024
|
I also tested this on the phone, webxdc picker works offline. Error for non-downloaded .xdcs is ugly (shows JSON toast), but that should be fixed on Android side I think. |
|
Thought I squash-merged this, apparently not :/ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use webxdc picker introduced in deltachat/deltachat-android#3463 offline after loading it once and attach previously downloaded .xdcs while being offline.