Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use i.delta.chat in qr codes #6223

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Use i.delta.chat in qr codes #6223

merged 2 commits into from
Nov 19, 2024

Conversation

Septias
Copy link
Collaborator

@Septias Septias commented Nov 18, 2024 •
edited
Loading

As discussed in #5467 we want to use i.delta.chat in QR codes in favor of OPENPGP4FPR: scheme. This PR does the replacement in get_securejoin_qr which is used in get_securejoin_qr_svg.

close #5467

@Septias
Use i.delta.chat in qr codes
eba0dbf 
As discussed in #5467 we want to use `i.delta.chat` in QR codes in favor
of `OPENPGP4FPR:` scheme. This PR does the replacement in
`get_securejoin_qr` which is used in `get_securejoin_qr_svg`.
@Septias Septias requested a review from r10s November 18, 2024 14:26
@r10s
Copy link
Member

r10s commented Nov 18, 2024

tests are failing and might need additional love.

and, if not yet there, we should make sure to have a test OPENPGP4FPR: still working (it is used eg, on i.delta.chat for the QR code in case is cannot intercept fully). the test becomes more important now as we would not immediately get aware when this part is failing(

@Septias
Copy link
Collaborator Author

Septias commented Nov 19, 2024 •
edited
Loading

There are six tests in qr.rs checking proper handling of OPENPGP4FPR qr codes for groups, secure join, fingerprints and more. I think this should be sufficient.

r10s
r10s approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, however, we need to test that in practise also after doing UI releases.

seems to be a good timing to get that in for that, 1.48 releases are mostly out and done

@Septias Septias merged commit 8f3be76 into main Nov 19, 2024
38 checks passed
@Septias Septias deleted the sk/use_i_deltachat_in_qr branch November 19, 2024 16:32
This was referenced Nov 27, 2024
Closed
Merged
r10s added a commit that referenced this pull request Nov 28, 2024
@r10s @iequidoo
docs: update dc_msg_get_info_type() and dc_get_securejoin_qr() (#6269)
da546d3 
this was partly missing at
#6223

this is not meant as being exhaustive :)

---------

Co-authored-by: iequidoo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change add-to-group/secure-join QR code data from OPENPGP4FPR:- to i.delta.chat-scheme
2 participants
@Septias @r10s