refactor: Don't update message state to OutMdnRcvd anymore
#5821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
approved these changes
Jul 31, 2024
This state can be computed from the `msgs_mdns` table without significant overhead as we have an index by msg_id there.
iequidoo
force-pushed
the
iequidoo/dont-store-OutMdnRcvd
branch
from
49a26e1 to
9a7fac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This state can be computed from the
msgs_mdnstable without significant overhead as we have an index by msg_id there. A little more code, but overall the logic is simpler.EDIT: This allows to add some
OutRcvdmessage state for received outgoing messages which doesn't need to be upgraded toOutMdnRcvdand to fix the scenario in #5813 by sorting such messages the same way asInFreshones.