fix: ignore event channel overflows #5605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
async-broadcast returns Overflowed error once if channel overflow happened. Public APIs such as get_next_event JSON-RPC method are only expecting an error if the channel is closed, so we should not propagate overflow error outside. In particular, Delta Chat Desktop stop receiving events completely if an error is returned once. If overflow happens, we should ignore it and try again until we get an event or an error because the channel is closed (in case of recv()) or empty (in case of try_recv()).
|
The problem exists since switch to async-broadcast in #5478. I discovered the problem while playing with realtime channels with webxdc and creating too many WebxdcRealtimeData events. |
Simon-Laux
approved these changes
May 20, 2024
iequidoo
reviewed
May 21, 2024
| Err(async_broadcast::RecvError::Overflowed(_)) => { | ||
| // Some events have been lost, | ||
| // but the channel is not closed. | ||
| continue; |
There was a problem hiding this comment.
Maybe it's worth returning a special event telling that some events are lost? I.e. if we don't see such an event in the log, then no events are missing
There was a problem hiding this comment.
PR adding this event: #5616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async-broadcast returns Overflowed error once
if channel overflow happened.
Public APIs such as get_next_event JSON-RPC method are only expecting an error if the channel is closed, so we should not propagate overflow error outside. In particular, Delta Chat Desktop
stop receiving events completely if an error
is returned once.
If overflow happens, we should ignore it
and try again until we get an event or an error because the channel is closed (in case of recv())
or empty (in case of try_recv()).