Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Parsing vCards for contacts sharing #5482

Merged
merged 10 commits into from
May 4, 2024
Merged

feat: Parsing vCards for contacts sharing #5482

merged 10 commits into from
May 4, 2024

Conversation

Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Apr 19, 2024

No description provided.

@link2xt
Copy link
Collaborator

link2xt commented Apr 20, 2024 •
edited
Loading

Can we use https://crates.io/crates/ical instead of rolling out our own parsing? It was tested a bit already and is maintained, see #5202

EDIT: I see, there is a comment in #5422 (comment)

@Hocuri Hocuri mentioned this pull request Apr 24, 2024
Closed
iequidoo
iequidoo reviewed Apr 25, 2024
View reviewed changes
deltachat-contact-tools/src/lib.rs Outdated Show resolved Hide resolved
deltachat-contact-tools/src/lib.rs Outdated Show resolved Hide resolved
deltachat-contact-tools/src/lib.rs Outdated Show resolved Hide resolved
deltachat-contact-tools/src/lib.rs Outdated Show resolved Hide resolved
deltachat-contact-tools/src/lib.rs Outdated Show resolved Hide resolved
@Hocuri Hocuri changed the title [WIP] Add API to for vcard-contact-sharing [WIP] Parsing and creating vcards for vcard-contact-sharing Apr 25, 2024
@iequidoo iequidoo force-pushed the hoc/parse-vcard-manually-2 branch 2 times, most recently from def137c to 4e0fbff Compare April 30, 2024 05:29
@Hocuri Hocuri changed the title [WIP] Parsing and creating vcards for vcard-contact-sharing Parsing and creating vcards for vcard-contact-sharing Apr 30, 2024
@Hocuri Hocuri requested review from iequidoo and link2xt April 30, 2024 14:37
@Hocuri Hocuri changed the title Parsing and creating vcards for vcard-contact-sharing Parsing vcards for vcard-contact-sharing Apr 30, 2024
@iequidoo iequidoo force-pushed the hoc/parse-vcard-manually-2 branch 2 times, most recently from 18d131d to bf7f8c5 Compare May 2, 2024 05:53
Hocuri
Hocuri commented May 3, 2024
View reviewed changes
Copy link
Collaborator Author

@Hocuri Hocuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I can't approve my own PRs unfortunately, but consider it approved). There are some small TODOs in the code, but I'll write myself a note to care about them later (they can be resolved after we shipped the feature).

@iequidoo iequidoo changed the title Parsing vcards for vcard-contact-sharing feat: Parsing vCards for contacts sharing May 4, 2024
Hocuri and others added 10 commits May 3, 2024 22:20
@Hocuri @iequidoo
Add basic parsing code
a5b092a
@Hocuri @iequidoo
Make parsing of name, addr, and timestamp work
c1bd666
@iequidoo
review suggestions
503aabe
@Hocuri @iequidoo
Add another test
b7daced
@Hocuri @iequidoo
Add some comments
53e0a2c
@iequidoo
parse_vcard: change param type to &str
dcc9802
@iequidoo
Rename profile_photo to profile_image
a8bb284 
Other fields of `VcardContact` are named like in the DC code, let's do the same for
`profile_image`. See `Contact::get_profile_image()` for the reference.
@iequidoo
remove the comment, the timestamp is correct
5a50d59
@iequidoo
Prefix test names with vcard
4da9d32 
Also rename `test_android_contact_export` to `test_vcard_android` for uniformity with
`test_thunderbird`.
@iequidoo
fix parsing datetime w/o a timezone
f4af046
@iequidoo iequidoo force-pushed the hoc/parse-vcard-manually-2 branch from bf7f8c5 to f4af046 Compare May 4, 2024 01:21
@iequidoo iequidoo merged commit 026f678 into main May 4, 2024
38 checks passed
@iequidoo iequidoo deleted the hoc/parse-vcard-manually-2 branch May 4, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iequidoo iequidoo iequidoo approved these changes

@link2xt link2xt Awaiting requested review from link2xt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hocuri @link2xt @iequidoo