fix: assign messages to chats based on not fully downloaded references #5458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/parent-download-message
branch
3 times, most recently
from
5ea05e2 to
bea2193
Compare
iequidoo
reviewed
Apr 12, 2024
src/chat.rs
Outdated
| { | ||
| // If `msg` is not fully downloaded or undecipherable, it may have been assigned to the | ||
| if msg.download_state == DownloadState::Undecipherable { | ||
| // If `msg` is not undecipherable, it may have been assigned to the |
There was a problem hiding this comment.
Partially downloaded messages are also potentially undecipherable. The only difference is that we can download them and (likely) validate their assignment to chat. Maybe just remove this comment?
link2xt
force-pushed
the
link2xt/parent-download-message
branch
from
bea2193 to
18714ee
Compare
link2xt
commented
Apr 12, 2024
| { | ||
| // If `msg` is not fully downloaded or undecipherable, it may have been assigned to the | ||
| // wrong chat (they often get assigned to the 1:1 chat with the sender). | ||
| if msg.download_state == DownloadState::Undecipherable { |
There was a problem hiding this comment.
Removing this condition breaks existing Python test test_undecipherable_group. We can also remove it and adjust the test, but I wanted to minimize the changes so e.g. if user has no download limit everything works the same as before.
iequidoo
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5347